-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spirv-val: Add SPV_KHR_ray_tracing storage class #4868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the VUIDs not attachable in RegisterStorageClassConsumer?
So right now waiting on KhronosGroup/Vulkan-Docs#1895 to add the VUs, if they decide to keep/add the missing ones I will come back and label them |
Maybe I'm confused but https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-StandaloneSpirv-IncomingRayPayloadKHR-04699 and other around there seem just like this. Restrictions on the execution models that can use a storage class. |
I guess my logic was these VUs language (and a few that are missing) are already listed in the SPV_KHR_ray_tracing spec |
@alan-baker added the VU and when the KhronosGroup/Vulkan-Docs#1895 is merged and upstreamed will add the final 2 labels |
8a97b07
to
f39338c
Compare
Had to fix that the Also think I fixed the CI issue with clang-format, not sure what version the CI is using and the |
6291d3a
to
6c16d89
Compare
yet I didn't touch that file, rebased, hope this finally fixes/pleases CI (cc @alan-baker ) |
Adds validation to make sure all the ray tracing
Storage Class
are using the correct execution model. AlsoHitAttributeKHR
andShaderRecordBufferKHR
have read/write limitations. There is already validation for the "cannot have initializers" marked asVUID-StandaloneSpirv-OpVariable-04651
(tasklist KhronosGroup/Vulkan-Docs#1402)