Fix AdaptiveCpp CI filter #1013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an error during filter generation, we previously excluded too many categories.
psalz
force-pushed
the
fix-acpp-ci-filter
branch
from
7921713 to
54fa563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bad news: There was an unfortunate interaction between the CI filter generation script and Ninja on the system I was running it on, leading to #874 essentially excluding all test categories for AdaptiveCpp. I only recently discovered this while looking at the CI runs for #872, for which AdaptiveCpp compiled the CTS in 2 seconds...
The good news: There's actually quite a lot categories that in fact do compile now (over 50%)!
cc @illuhad