-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility: Only use sycl::half
if SYCL_CTS_ENABLE_HALF_TESTS is set
#872
base: main
Are you sure you want to change the base?
Conversation
From what I see, they are filtered out automatically: Lines 162 to 164 in 42e9081
|
g++-13 implements already https://en.cppreference.com/w/cpp/types/floating-point from C++23. @fknorr Go for it! :-) |
@fknorr Some merge from upstream? |
I was not aware of the _Float16 support in newer GCC - this PR might not be required anymore for SimSYCL, I can check after merging #870 . |
Sorry for abandoning this for so long! I've rebased on top of #874 to avoid future merge conflicts. @keryell unfortunately we still need the Edit: DPC++ passes these - but how? |
@bader's suggestion on reordering the functions in I've gone ahead and re-grouped all definitions within the file according to feature macros:
A few functions (like |
7840ed6
to
0070e56
Compare
This PR improves compatibility with implementations that do not expose the
sycl::half
type (notably, SimSYCL built with GCC).There might be additional usages I missed, in tests that SimSYCL is currently unable to compile for other reasons.
Question to the reviewers: Is it necessary to exclude some translation units in CMake when the file names are
*fp16.cpp
or are these handled automatically?