Skip to content

Calculated the bounds of the imported SkinnedMeshRenderer. #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XtroTheArctic wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Calculated the bounds of the imported SkinnedMeshRenderer. #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddb5cb6
Calculated the bounds of the imported SkinnedMeshRenderer.
XtroTheArctic Jun 29, 2025
106ac9d
Merge remote-tracking branch 'official/dev' into dev
XtroTheArctic Jul 13, 2025
dc108be
Merge branch 'dev' into feature/876-CalculateBounds
XtroTheArctic Jul 13, 2025
8e47bb0
Fixed SkinnedMeshRenderer bounding box calculation.
XtroTheArctic Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Editor/Scripts/GLTFImporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,7 @@ private void CreateGLTFScene(GLTFImportContext context, out GameObject scene,
BlendShapeFrameWeight = _blendShapeFrameWeight,
CameraImport = _importCamera,
DeduplicateResources = _deduplicateResources,
ScaleFactor = _scaleFactor,
};

using (var stream = File.OpenRead(projectFilePath))
Expand Down
42 changes: 35 additions & 7 deletions Runtime/Scripts/GLTFSceneImporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,12 @@ public class ImportOptions
public CameraImportOption CameraImport = CameraImportOption.ImportAndCameraDisabled;
public RuntimeTextureCompression RuntimeTextureCompression = RuntimeTextureCompression.None;
public BlendShapeFrameWeightSetting BlendShapeFrameWeight = new BlendShapeFrameWeightSetting(BlendShapeFrameWeightSetting.MultiplierOption.Multiplier1);
public float ScaleFactor = 1;

#if UNITY_EDITOR
public GLTFImportContext ImportContext = new GLTFImportContext(null, GLTFSettings.GetOrCreateSettings());
#else
public GLTFImportContext ImportContext = new GLTFImportContext(GLTFSettings.GetOrCreateSettings());
public GLTFImportContext ImportContext = new GLTFImportContext(GLTFSettings.GetOrCreateSettings());
#endif

[NonSerialized]
Expand Down Expand Up @@ -1008,8 +1009,6 @@ protected virtual async Task ConstructNode(Node node, int nodeIndex, Cancellatio
nodeObj.transform.localRotation = rotation;
nodeObj.transform.localScale = scale;



async Task CreateNodeComponentsAndChilds(bool ignoreMesh = false, bool onlyMesh = false)
{
// If we're creating a really large node, we need it to not be visible in partial stages. So we hide it while we create it
Expand Down Expand Up @@ -1048,8 +1047,24 @@ async Task CreateNodeComponentsAndChilds(bool ignoreMesh = false, bool onlyMesh
if (node.Skin != null)
await SetupBones(node.Skin.Value, renderer, cancellationToken);

// morph target weights
if (weights != null)
// calculate SkinnedMeshRenderer local bounds by applying bone transforms to make it consistent with Unity's FBX importer effectively fixing: https://github.com/KhronosGroup/UnityGLTF/issues/876
if (renderer.rootBone == null) renderer.localBounds = unityMesh.bounds;
else
{
var bakedMesh = new Mesh();
renderer.BakeMesh(bakedMesh, true);

var bounds = TransformBounds(renderer.rootBone.worldToLocalMatrix * renderer.transform.localToWorldMatrix, bakedMesh.bounds);
bounds.center *= _options.ScaleFactor;
bounds.size *= _options.ScaleFactor;

renderer.localBounds = bounds;

Object.DestroyImmediate(bakedMesh);
}

// morph target weights
if (weights != null)
{
for (int i = 0; i < weights.Count; ++i)
{
Expand Down Expand Up @@ -1206,8 +1221,21 @@ async Task CreateNodeComponentsAndChilds(bool ignoreMesh = false, bool onlyMesh
progressStatus.NodeLoaded++;
progress?.Report(progressStatus);
}

private async Task ConstructBufferData(Node node, CancellationToken cancellationToken)

Bounds TransformBounds(Matrix4x4 matrix, Bounds bounds)
{
var extents = bounds.extents;
var ax = matrix.MultiplyVector(new Vector3(extents.x, 0, 0));
var ay = matrix.MultiplyVector(new Vector3(0, extents.y, 0));
var az = matrix.MultiplyVector(new Vector3(0, 0, extents.z));
var x = Mathf.Abs(ax.x) + Mathf.Abs(ay.x) + Mathf.Abs(az.x);
var y = Mathf.Abs(ax.y) + Mathf.Abs(ay.y) + Mathf.Abs(az.y);
var z = Mathf.Abs(ax.z) + Mathf.Abs(ay.z) + Mathf.Abs(az.z);

return new Bounds(matrix.MultiplyPoint3x4(bounds.center), new Vector3(x, y, z) * 2f);
}

private async Task ConstructBufferData(Node node, CancellationToken cancellationToken)
{
cancellationToken.ThrowIfCancellationRequested();

Expand Down