Added test cases for structs as out and inout parameters. #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The highp variant of these tests fails on certain GPUs. Regression tests for the Chromium bugs http://crbug.com/851870 and http://crbug.com/851873. Test cases originally from mrdoob/three.js#14137 .
|
Verified that these tests fail on one of the affected phones, and pass on a different one as well as on desktop. Please review. @Oletus @jdashg @kainino0x @RafaelCintron @grorg in particular. Thanks. |
kainino0x
approved these changes
Jul 9, 2018
|
@kainino0x thanks for your review. I just tried writing a variant of these tests which rendered repeatedly with these shaders, and couldn't reproduce the lockup of the phone which was reported with one of the variants. For this reason, I'm landing just this version which does a single render. It catches the driver bug well enough. |
alegal-arm
pushed a commit
to KhronosGroup/VK-GL-CTS
that referenced
this pull request
Aug 27, 2018
Structs with lowp, mediump and highp (when supported in fragment shaders) members are tested as inout and out parameters in both ES 2.0 and 3.0 shaders. The highp variant of this test catches a bug which was found by the Three.js community in mrdoob/three.js#14137 . Similar tests were integrated into the WebGL conformance suite in KhronosGroup/WebGL#2663 . Verified on: Qualcomm Adreno 308 (LG Aristo) - bug reproduces in both ES2 and ES3 highp fragment shaders Qualcomm Adreno 540 (Pixel 2), NVIDIA Tegra (SHIELD Tablet) - all tests pass New tests: dEQP-GLES[23].functional.shaders.struct.local.parameter_inout_* dEQP-GLES[23].functional.shaders.struct.local.parameter_out_* VK-GL-CTS Issue 1280 Change-Id: Ie332aede0ad52453815d9e123145ec035009430b
alegal-arm
pushed a commit
to KhronosGroup/VK-GL-CTS
that referenced
this pull request
Aug 30, 2018
Structs with lowp, mediump and highp (when supported in fragment shaders) members are tested as inout and out parameters in both ES 2.0 and 3.0 shaders. The highp variant of this test catches a bug which was found by the Three.js community in mrdoob/three.js#14137 . Similar tests were integrated into the WebGL conformance suite in KhronosGroup/WebGL#2663 . Verified on: Qualcomm Adreno 308 (LG Aristo) - bug reproduces in both ES2 and ES3 highp fragment shaders Qualcomm Adreno 540 (Pixel 2), NVIDIA Tegra (SHIELD Tablet) - all tests pass New tests: dEQP-GLES[23].functional.shaders.struct.local.parameter_inout_* dEQP-GLES[23].functional.shaders.struct.local.parameter_out_* VK-GL-CTS Issue 1280 Change-Id: Ie332aede0ad52453815d9e123145ec035009430b (cherry picked from commit 3b0365b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highp variant of these tests fails on certain GPUs.
Regression tests for the Chromium bugs http://crbug.com/851870 and
http://crbug.com/851873.
Test cases originally from
mrdoob/three.js#14137 .