Add JSON schemas to AsciiDoctor output. #1907
Conversation
|
for #1901 |
|
|
||
| WETZEL = npx wetzel | ||
| SCHEMALINK = https://github.com/KhronosGroup/glTF/tree/master/specification/2.0/schema | ||
| SCHEMALINK = schema | ||
| EMBEDSCHEMA = JsonSchemaReference.adoc | ||
|
|
||
| # Base name of the generated properties reference file | ||
| PROPREF = PropertiesReference | ||
| # Schema files to leave out of $(PROPREF) | ||
| IGNORESCHEMA = '["gltfchildofrootproperty.schema.json", "gltfid.schema.json", "gltfproperty.schema.json"]' | ||
| $(PROPREF).adoc: $(wildcard schema/*.json) |
There was a problem hiding this comment.
Would add $(EMBEDSCHEMA) to targets here. Might want some sort of npx dependency too, but I'm not sure how that would work since the wetzel files are pulled from a remote.
There was a problem hiding this comment.
I think in the next round of changes I'm going to add the version number onto the end of wetzel. Specifically, something like this:
WETZEL = npx wetzel@0.1.0-dev.1.2
That way, updates to new versions of wetzel must be manually done in the Makefile, not just pulled in automatically whenever someone publishes. This would provide more stability of the history, for example pulling an old commit and re-running the old documentation would use the specific version of wetzel available at that point in history, and should exactly regenerate what the docs were back then. Likewise, changes to the docs introduced by new wetzel versions could be found with bisect, etc.
|
I'll accept once you've made those changes, unless you want to hold off. |
|
Going to go ahead and merge this now and make the changes I recommended above - something I wanted to tweak in the appendix section layout and it will be easier to check in my branch. |
See discussion: #1907 (comment)
@oddhack This is a PR into your branch, to add the JSON schema file contents.
via CesiumGS/wetzel#51