Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add 6.35mm and speakON connectors #1145

Merged
merged 55 commits into from
May 3, 2020
Merged

Add 6.35mm and speakON connectors #1145

merged 55 commits into from
May 3, 2020

Conversation

evanshultz
Copy link
Collaborator

@evanshultz evanshultz commented Dec 5, 2018 •
edited
Loading

I started developing these footprints some time ago based on #191. While I hope everything is ready, my eyes are blearly and #1012 makes me want to get this pushed now, gathering feedback from others, instead of further delay as they look good to me. There could be some personal preference in that how I designed them so let's start the discussion and progress toward merging these. Certainly there can be some changes or improvements to be made. This is massive number of footprints and I don't want to dimension each one, so perhaps a visual review will suffice for now? If there are "nice to have" things, like contoured courtyard, I'd rather have an issue to capture that and get these merged rather than delay.

Checklist of reviewed and fixed, if needed, series:

  • A
  • AA
  • B
  • Combo A
  • Combo I
  • Vertical Jacks
  • SpeakON Combo
  • SpeakON Chassis
  • STX
  • Slim Jacks
  • M
  • Stacking Jacks

I selected pin numbers to match the corresponding audio jack symbols (see KiCad/kicad-symbols#1076):

  • Numbers for XLR pins
  • "T", "R", and "S" for barrel 1/4" / 6.35mm pins
  • "G" for a dedicated ground pin
  • "NO", "N", and "NC" for an unconnected switch

If a pin 1 does not exist, the origin is placed at pin "T" or "T1" or "1+". Pin 1 is in the top left or top middle for all but vertical XLRs where it looks super weird to have pin 1 at the top (it's often in the middle of a side) so I left them with the XLR right side up.

Jan made a good comment about being able to use the footprint filters at #191 (comment), and I think this will work. By allowing filtering of the type of footprint to go with the symbol, with the symbols I made at KiCad/kicad-symbols#1076, filtering by pin names and numbers does the rest.

There are too many footprints to show here all individually, but here are images of several of them. For the vertical XLRs I used Neutrik's DXF drawings and then copied fab elements to the silk layer (avoiding pads where necessary). This places silk on top of the fab lines and under the component, but that isn't disallowed according to KLC (and saved a ton of time due to the complexity of the shapes).
image
image
image
image

CI warnings are acceptable:

  1. Rectangular pin 1 is not required because all are keyed (sometimes obviously so but at least by the mounting holes)
  2. As mentioned above, not all have a pin named "1" and the substitute pin designator is detailed above.

Here is a list of all footprints I've submitted:

https://www.neutrik.com/en/neutrik/products/xlr-connectors/xlr-chassis-connectors/a-series
NC3FAH [http://www.neutrik.com/en/product/nc3fah]
NC3FAH-0 [http://www.neutrik.com/en/product/nc3fah-0]
NC3FAH1 [http://www.neutrik.com/en/product/nc3fah1]
NC3FAH1-0 [http://www.neutrik.com/en/product/nc3fah1-0]
NC3FAH1-DA [http://www.neutrik.com/en/product/nc3fah1-da]
NC3FAH2 [http://www.neutrik.com/en/product/nc3fah2]
NC3FAH2-0 [http://www.neutrik.com/en/product/nc3fah2-0]
NC3FAH2-DA [http://www.neutrik.com/en/product/nc3fah2-da]
NC3FAHL-0 [http://www.neutrik.com/en/product/nc3fahl-0]
NC3FAHL1 [http://www.neutrik.com/en/product/nc3fahl1]
NC3FAHL1-0 [http://www.neutrik.com/en/product/nc3fahl1-0]
NC3FAHR-0 [http://www.neutrik.com/en/product/nc3fahr-0]
NC3FAHR1 [http://www.neutrik.com/en/product/nc3fahr1]
NC3FAHR1-0 [http://www.neutrik.com/en/product/nc3fahr1-0]
NC3FAHR2 [http://www.neutrik.com/en/product/nc3fahr2]
NC3FAHR2-0 [http://www.neutrik.com/en/product/nc3fahr2-0]
NC3FAV [http://www.neutrik.com/en/product/nc3fav]
NC3FAV-0 [http://www.neutrik.com/en/product/nc3fav-0]
NC3FAV1 [http://www.neutrik.com/en/product/nc3fav1]
NC3FAV1-0 [http://www.neutrik.com/en/product/nc3fav1-0]
NC3FAV1-DA [http://www.neutrik.com/en/product/nc3fav1-da]
NC3FAV2 [http://www.neutrik.com/en/product/nc3fav2]
NC3FAV2-0 [http://www.neutrik.com/en/product/nc3fav2-0]
NC3FAV2-DA [http://www.neutrik.com/en/product/nc3fav2-da]
NC3MAFH-PH [http://www.neutrik.com/en/product/nc3mafh-ph] (not an XLR but is intended to be interchangeable; note the drawing shows an extra hole)
NC3MAH [http://www.neutrik.com/en/product/nc3mah]
NC3MAH-0 [http://www.neutrik.com/en/product/nc3mah-0]
NC3MAHL [http://www.neutrik.com/en/product/nc3mahl]
NC3MAHR [http://www.neutrik.com/en/product/nc3mahr]
NC3MAMH-PH [http://www.neutrik.com/en/product/nc3mamh-ph] (not an XLR but is intended to be interchangeable; note the drawing shows extra holes)
NC3MAV [http://www.neutrik.com/en/product/nc3mav]
NC3MAV-0 [http://www.neutrik.com/en/product/nc3mav-0]
NC4FAH [http://www.neutrik.com/en/product/nc4fah]
NC4FAH-0 [http://www.neutrik.com/en/product/nc4fah-0]
NC4FAV [http://www.neutrik.com/en/product/nc4fav]
NC4FAV-0 [http://www.neutrik.com/en/product/nc4fav-0]
NC4MAH [http://www.neutrik.com/en/product/nc4mah]
NC4MAV [http://www.neutrik.com/en/product/nc4mav]
NC5FAH [https://www.neutrik.com/en/product/nc5fah]
NC5FAH-0 [https://www.neutrik.com/en/product/nc5fah-0]
NC5FAH-DA [https://www.neutrik.com/en/product/nc5fah-da]
NC5FAV [https://www.neutrik.com/en/product/nc5fav]
NC5FAV-DA [https://www.neutrik.com/en/product/nc5fav-da]
NC5FAV-SW [https://www.neutrik.com/en/product/nc5fav-sw]
NC5MAH [https://www.neutrik.com/en/product/nc5mah]
NC5MAV [https://www.neutrik.com/en/product/nc5mav]
NC5MAV-SW [https://www.neutrik.com/en/product/nc5mav-sw]

https://www.neutrik.com/en/neutrik/products/xlr-connectors/xlr-chassis-connectors/aa-series
NC3FAAH [http://www.neutrik.com/en/product/nc3faah]
NC3FAAH-0 [http://www.neutrik.com/en/product/nc3faa-0]
NC3FAAH1 [http://www.neutrik.com/en/product/nc3faah1]
NC3FAAH1-0 [http://www.neutrik.com/en/product/nc3faa1-0]
NC3FAAH1-DA [http://www.neutrik.com/en/product/nc3faa1-da]
NC3FAAH2 [http://www.neutrik.com/en/product/nc3faah2]
NC3FAAH2-0 [http://www.neutrik.com/en/product/nc3faah-0]
NC3FAAV [http://www.neutrik.com/en/product/nc3faav]
NC3FAAV-0 [http://www.neutrik.com/en/product/nc3faav-0]
NC3FAAV1 [http://www.neutrik.com/en/product/nc3faav1]
NC3FAAV1-0 [http://www.neutrik.com/en/product/nc3faav1-0]
NC3FAAV1-DA [http://www.neutrik.com/en/product/nc3faav1-da]
NC3FAAV2 [http://www.neutrik.com/en/product/nc3faav2]
NC3FAAV2-0 [http://www.neutrik.com/en/product/nc3faav2-0]
NC3MAAH [http://www.neutrik.com/en/product/nc3maah]
NC3MAAH-0 [http://www.neutrik.com/en/product/nc3maah-0]
NC3MAAH-1 [http://www.neutrik.com/en/product/nc3maah-1]
NC3MAAV [http://www.neutrik.com/en/product/nc3maav]
NC3MAAV-0 [http://www.neutrik.com/en/product/nc3maav-0]
NC3MAAV-1 [http://www.neutrik.com/en/product/nc3maav-1]

https://www.neutrik.com/en/neutrik/products/xlr-connectors/xlr-chassis-connectors/b-series
NC3FBH1 [http://www.neutrik.com/en/product/nc3fbh1]
NC3FBH1-B [http://www.neutrik.com/en/product/nc3fbh1-b]
NC3FBH1-DA [http://www.neutrik.com/en/product/nc3fbh1-da]
NC3FBH1-E [http://www.neutrik.com/en/product/nc3fbh1-e]
NC3FBH2 [http://www.neutrik.com/en/product/nc3fbh2]
NC3FBH2-B [http://www.neutrik.com/en/product/nc3fbh-b]
NC3FBH2-DA [http://www.neutrik.com/en/product/nc3fbh-da]
NC3FBH2-E [http://www.neutrik.com/en/product/nc3fbh-e]
NC3FBHL1 [http://www.neutrik.com/en/product/nc3fbhl1]
NC3FBV1 [http://www.neutrik.com/en/product/nc3fbv1]
NC3FBV1-0 [http://www.neutrik.com/en/product/nc3fbv1-0]
NC3FBV1-B [http://www.neutrik.com/en/product/nc3fbv1-b]
NC3FBV1-DA [http://www.neutrik.com/en/product/nc3fbv1-da]
NC3FBV2 [http://www.neutrik.com/en/product/nc3fbv2]
NC3FBV2-B [http://www.neutrik.com/en/product/nc3fbv2-b]
NC3FBV2-DA [http://www.neutrik.com/en/product/nc3fbv2-da]
NC3FBV2-SW [http://www.neutrik.com/en/product/nc3fbv2-sw]
NC3MBH [http://www.neutrik.com/en/product/nc3mbh]
NC3MBH-0 [http://www.neutrik.com/en/product/nc3mbh-0]
NC3MBH-1 [http://www.neutrik.com/en/product/nc3mbh-1]
NC3MBH-B [http://www.neutrik.com/en/product/nc3mbh-b]
NC3MBH-E [http://www.neutrik.com/en/product/nc3mbh-e]
NC3MBHL [http://www.neutrik.com/en/product/nc3mbhl]
NC3MBHL-B [http://www.neutrik.com/en/product/nc3mbhl-b]
NC3MBHR [http://www.neutrik.com/en/product/nc3mblr]
NC3MBHR-B [http://www.neutrik.com/en/product/nc3mblr-b]
NC3MBV [http://www.neutrik.com/en/product/nc3mbv]
NC3MBV-0 [http://www.neutrik.com/en/product/nc3mbv-0]
NC3MBV-1 [http://www.neutrik.com/en/product/nc3mbv-1]
NC3MBV-B [http://www.neutrik.com/en/product/nc3mbv-b]
NC3MBV-E [http://www.neutrik.com/en/product/nc3mbv-e]
NC3MBV-SW [http://www.neutrik.com/en/product/nc3mbv-sw]
NC4FBH [https://www.neutrik.com/en/product/nc4fbh]
NC4FBV [https://www.neutrik.com/en/product/nc4fbv]
NC4MBH [https://www.neutrik.com/en/product/nc4mbh]
NC4MBV [https://www.neutrik.com/en/product/nc4mbv]
NC5FBH [https://www.neutrik.com/en/product/nc5fbh]
NC5FBH-B [https://www.neutrik.com/en/product/nc5fbh-b]
NC5FBV [https://www.neutrik.com/en/product/nc5fbv]
NC5FBV-B [https://www.neutrik.com/en/product/nc5fbv-b]
NC5FBV-SW [https://www.neutrik.com/en/product/nc5fbv-sw] (Neutrik's 3D model and drawing don't match so I approximated)
NC5MBH [https://www.neutrik.com/en/product/nc5mbh]
NC5MBH-B [https://www.neutrik.com/en/product/nc5mbh-b]
NC5MBV [https://www.neutrik.com/en/product/nc5mbv]
NC5MBV-B [https://www.neutrik.com/en/product/nc5mbv-b]
NC5MBV-SW [https://www.neutrik.com/en/product/nc5mbv-sw]

https://www.neutrik.com/en/neutrik/products/plugs-jacks/jacks/combo-a-series
NCJ6FA-H [http://www.neutrik.com/en/product/ncj6fa-h]
NCJ6FA-H-0 [http://www.neutrik.com/en/product/ncj6fa-h-0]
NCJ6FA-H-DA [http://www.neutrik.com/en/product/ncj6fa-h-da]
NCJ6FA-V [http://www.neutrik.com/en/product/ncj6fa-v]
NCJ6FA-V-0 [http://www.neutrik.com/en/product/ncj6fa-v-0]
NCJ6FA-V-DA [http://www.neutrik.com/en/product/ncj6fa-v-da]

https://www.neutrik.com/en/neutrik/products/plugs-jacks/jacks/combo-i-series
NCJ5FI-H [http://www.neutrik.com/en/product/ncj5fi-h]
NCJ5FI-H-0 [http://www.neutrik.com/en/product/ncj5fi-h-0]
NCJ5FI-V [http://www.neutrik.com/en/product/ncj5fi-v]
NCJ5FI-V-0 [http://www.neutrik.com/en/product/ncj5fi-v-0]
NCJ6FI-H [http://www.neutrik.com/en/product/ncj6fi-h]
NCJ6FI-H-0 [http://www.neutrik.com/en/product/ncj6fi-h-0]
NCJ6FI-V [http://www.neutrik.com/en/product/ncj6fi-v]
NCJ6FI-V-0 [http://www.neutrik.com/en/product/ncj6fi-v-0]
NCJ9FI-H [http://www.neutrik.com/en/product/ncj9fi-h]
NCJ9FI-H-0 [http://www.neutrik.com/en/product/ncj9fi-h-0]
NCJ9FI-V [http://www.neutrik.com/en/product/ncj9fi-v]
NCJ9FI-V-0 [http://www.neutrik.com/en/product/ncj9fi-v-0]
NCJ10FI-H [http://www.neutrik.com/en/product/ncj10fi-h]
NCJ10FI-H-0 [http://www.neutrik.com/en/product/ncj10fi-h-0]
NCJ10FI-V [http://www.neutrik.com/en/product/ncj10fi-v]
NCJ10FI-V-0 [http://www.neutrik.com/en/product/ncj10fi-v-0]

https://www.neutrik.com/en/neutrik/products/plugs-jacks/jacks/1-4-vertical-jacks
NJ2FD-V [http://www.neutrik.com/en/product/nj2fd-v]
NJ3FD-V [http://www.neutrik.com/en/product/nj3fd-v]
NJ5FD-V [http://www.neutrik.com/en/product/nj5fd-v]
NJ6FD-V [http://www.neutrik.com/en/product/nj6fd-v]
NJ6TB-V [http://www.neutrik.com/en/product/nj6tb-v]

https://www.neutrik.com/en/neutrik/products/plugs-jacks/jacks/speakon-combo
NLJ2MD-H [http://www.neutrik.com/en/product/nlj2md-h]
NLJ2MD-V [http://www.neutrik.com/en/product/nlj2md-v]

https://www.neutrik.com/en/neutrik/products/speakon-loudspeaker-connectors/speakon-chassis-connectors/speakon-chassis-connectors
NL2MD-H [http://www.neutrik.com/en/product/nl2md-h]
NL2MD-V [http://www.neutrik.com/en/product/nl2md-v]
NL4MD-H [http://www.neutrik.com/en/product/nl4md-h]
NL4MD-H-1 [http://www.neutrik.com/en/product/nl4md-h-1]
NL4MD-H-2 [https://www.neutrik.com/en/product/nl4md-h-2]
NL4MD-H-3 [http://www.neutrik.com/en/product/nl4md-h-3]
NL4MD-V [http://www.neutrik.com/en/product/nl4md-v]
NL4MD-V-1 [https://www.neutrik.com/en/product/nl4md-v-1]
NL4MD-V-2 [https://www.neutrik.com/en/product/nl4md-v-2]
NL4MD-V-R [http://www.neutrik.com/en/product/nl4md-v-r]
NL4MD-V-S [http://www.neutrik.com/en/product/nl4md-v-s]
NL8MD-V [http://www.neutrik.com/en/product/nl8md-v]
NL8MD-V-1 [http://www.neutrik.com/en/product/nl8md-v-1]

https://www.neutrik.com/en/neutrik/products/speakon-loudspeaker-connectors/speakon-chassis-connectors/stx-series
NLT4MD-V [https://www.neutrik.com/en/product/nlt4md-v]

https://www.neutrik.com/en/neutrik/products/plugs-jacks/jacks/slim-jacks
NRJ3HF-1 [http://www.neutrik.com/en/product/nrj3hf-1]
NJR4HF [http://www.neutrik.com/en/product/nrj4hf]
NJR4HF-1 [http://www.neutrik.com/en/product/nrj4hf-1]
NJR4HH [http://www.neutrik.com/en/product/nrj4hh]
NJR4HH-1 [http://www.neutrik.com/en/product/nrj4hh-1]
NRJ6HF [http://www.neutrik.com/en/product/nrj6hf]
NRJ6HF-AU [http://www.neutrik.com/en/product/nrj6hf-au]
NRJ6HF-1 [http://www.neutrik.com/en/product/nrj6hf-1]
NRJ6HF-1-AU [http://www.neutrik.com/en/product/nrj6hf-1-au]
NRJ6HH [http://www.neutrik.com/en/product/nrj6hh]
NRJ6HH-AU [http://www.neutrik.com/en/product/nrj6hh-au]
NRJ6HH-1 [http://www.neutrik.com/en/product/nrj6hh-1]
NRJ6HM-1 [http://www.neutrik.com/en/product/nrj6hm-1]
NRJ6HM-1-AU [http://www.neutrik.com/en/product/nrj6hm-1-au]
NRJ6HM-1-PRE [http://www.neutrik.com/en/product/nrj6hm-1-pre]

https://www.neutrik.com/en/neutrik/products/plugs-jacks/jacks/m-series
NMJ4HCD2 [http://www.neutrik.com/en/product/nmj4hcd2]
NMJ4HFD2 [http://www.neutrik.com/en/product/nmj4hfd2]
NMJ4HFD3 [http://www.neutrik.com/en/product/nmj4hfd3]
NMJ4HHD2 [http://www.neutrik.com/en/product/nmj4hhd2]
NMJ6HCD2 [http://www.neutrik.com/en/product/nmj6hcd2]
NMJ6HCD3 [http://www.neutrik.com/en/product/nmj6hcd3]
NMJ6HFD2 [http://www.neutrik.com/en/product/nmj6hfd2]
NMJ6HFD2-AU [http://www.neutrik.com/en/product/nmj6hfd2-au]
NMJ6HFD3 [http://www.neutrik.com/en/product/nmj6hfd3]
NMJ6HFD4 [http://www.neutrik.com/en/product/nmj6hfd4]
NMJ6HHD2 [http://www.neutrik.com/en/product/nmj6hhd2]

https://www.neutrik.com/en/neutrik/products/plugs-jacks/jacks/stacking-jacks
NSJ8HC [http://www.neutrik.com/en/product/nsj8hc]
NSJ8HL [http://www.neutrik.com/en/product/nsj8hl]
NSJ12HC [http://www.neutrik.com/en/product/nsj12hc]
NSJ12HF-1 [http://www.neutrik.com/en/product/nsj12hf-1]
NSJ12HH-1 [http://www.neutrik.com/en/product/nsj12hh-1]
NSJ12HL [http://www.neutrik.com/en/product/nsj12hl]

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@diegoherranz
Copy link
Collaborator

Many thanks for preparing this. The audio connectors symbols and footprints are starting to look awesome!
Out of curiosity, have these been scripted?

@evanshultz
Copy link
Collaborator Author

Thanks!

The XLRs I'll post soon. The vertical ones look like this:
image

They have not been scripted. There were a few reasons:

  1. Text editing and the Move Exactly feature made creating all these rectangular ones pretty fast. Making a script likely wouldn't have saved much time.
  2. These are such unique shapes and sizes that making a script for them wouldn't apply to other footprints. It would require figuring out how to capture data and then write out these footprints with all of their odd shapes, but even then the script wouldn't be something anyone could use to build other footprints in the future.
  3. If they need to be updated later for a library change (like courtyard offset or line widths or something), that will affect a whole slew of other handmade footprints. So a script to make per-footprint updates will hopefully cover these and other footprints as well.

@DanSGiesbrecht DanSGiesbrecht added Enhancement Improves existing footprint in the library Pending changes Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Dec 10, 2018
@diegoherranz
Copy link
Collaborator

It was more of a curiosity thing and was wondering whether Neutrik provided some sort of parseable data (e.g. spreadsheet).

As you said, there are too many footprints to do a thorough check on each, but I'll try reviewing a few ones. Do you expect any change on the footprints already submitted? Or are they ready to be reviewed?

Thanks

@evanshultz
Copy link
Collaborator Author

I'm not aware of any changes needed for the footprints committed already, but let me know if you do see anything that should or could be changed.

If you have any feedback on the vertical XLRs, I'd really appreciate hearing about it first before I push any of them.

@diegoherranz
Copy link
Collaborator

diegoherranz commented Dec 12, 2018 •
edited
Loading

What I've been checking so far looks pretty good. I'll report what I've checked.

A couple questions:

  • There are quite a few Jacks which have a gold version, e.g. NRJ6HF and NRJ6HF-AU.
    Currently, there are two different footprints, one for each even if they identical except for the description and the name. Is that needed? Is it because we expect to have different 3D models for them?
  • Similar for those with half/full thread. Which could maybe use a wildcard instead? Again, it wouldn't work if we expect different 3D models.

I have to say that I'm happy as is, it's just to understand the reasoning behind.

Also, for the M series (https://www.neutrik.com/en/neutrik/products/plugs-jacks/jacks/m-series), where did you get the dimension for this? I can't find it on the drawing.
dims

Thanks!

@evanshultz
Copy link
Collaborator Author

The gold version, threading, black version, different grounding styles, etc. are all because of a unique 3D model. You are correct.

I believe I pulled that dimension from the 3D model Neutrik provided, perhaps with some rounding up since their specified dimensions were generally smaller than the dimensions on the drawing (which is their "guarantee" on part size).

@diegoherranz
Copy link
Collaborator

Thanks for the explanation.

I've checked that dimension on the 3D model of the NMJ4HHD2 and the footprint doesn't match.
8.50mm on the footprint vs 8.70 on the 3D model

nmj4hhd2_footprint
nmj4hhd2

I've also check on the NMJ6HCD3 and the same thing happens.

Thanks!

@evanshultz
Copy link
Collaborator Author

I'm not sure what happened. I will check next week. Thanks for checking and letting me know!

I've pushed the XLR footprints (save two where the documentation and pictures from Neutrik's website don't match). I also pushed another set of 6.35mm footprints which I missed earlier.

@evanshultz
Copy link
Collaborator Author

@diegoherranz
I'm not sure how I ended up with 8.5mm on the horizontal 6.35mm jack, and I'm not sure that Neutrik's model is correct, but let's go with 8.7mm since that seems to be the best info we have. I confirmed this dimension on all four M series PNs I submitted which have a 3D model. Fixed!

Any other issues or comments?

@diegoherranz
Copy link
Collaborator

Thanks for the changes, @evanshultz.

I'm collecting notes of all what I'm reviewing. All looking good so far.
Please allow me a few more days to report it here.

Thanks!

@evanshultz
Copy link
Collaborator Author

@diegoherranz
Let me know when you're ready to provide feedback on this item. I know it's a lot to look at, so thanks for volunteering!

@diegoherranz
Copy link
Collaborator

diegoherranz commented Jan 10, 2019 •
edited
Loading

I've been on holidays and I thought I would have more time to look at this, but time flies!
I'll try to finish the review this weekend and report all the checks I've done.

@diegoherranz
Copy link
Collaborator

diegoherranz commented Jan 19, 2019 •
edited
Loading

M series review

I've reviewed a few parts (too many to check them all). I've tried to select parts so that the different variants/options are checked on at least one part.

Parts which look OK:

NMJ6HFD4

  • It's the only one with fishtail pins (-D4) and it correctly uses 1.5mm holes instead of 1.4mm.
  • Pins pitch (x and y) correct: 6.35mm and 16.23mm
  • Pin assignment correct
  • Pins offset to body correct (4.35 mm to frontal face)
  • Dimensions on the long axis:
    • 21 mm main part
    • 3 mm backend
    • 8.85 mm nose
  • Dimensions on the short axis
    • 8.7 mm backend (as discussed above)
    • 18.20 mm main part
    • 11 mm nose. This is not in the drawing, but I've measured ~10.8 mm on real connectors and the 3D model for the NMJ6HHD2 measures ~11.1. I think that 11mm is probably good enough.

NMJ6HFD2

  • Holes are 1.4mm (correct for -D2)
  • Compared to NMJ6HFD4 (using diff viewer):
    • Those two connectors are identical except for the pins so there should be minimal differences
    • All the same except the holes mentioned above. The pads are a bit bigger too, and hence some silkscreen changes.

NMJ4HFD2
Compared to NMJ6HFD2 (using diff viewer):

  • It should all be the same except for having two fewer pins
  • R and RN pins missing - OK
  • Small silkscreen differences

NMJ6HFD3

  • Holes are 1.4mm (correct for -D3, offset pins)
  • Compared to NMJ6HFD2 (using diff viewer):
    • Pins on the same locations (because the origin is at the T pin)
  • 2.9 mm from S pin to frontal face - OK
  • 5.4mm from T pin to back - OK
  • Bulge at the back is 3mm - OK

NMJ6HFD2-AU
Identical to NMJ6HFD2 except for description, link, name, etc.

Parts which need some fixes:

NMJ4HCD2

@diegoherranz
Copy link
Collaborator

diegoherranz commented Jan 19, 2019 •
edited
Loading

Slim series review

Parts which look OK:

NRJ6HF

  • Holes for pins are 1.5 mm
  • Pins pitch (x and y) correct: 6.35 mm and 11.43 mm
  • 7.35 mm from T pin to back
  • 4.25 mm from S pin to frontal face
  • 7.45 mm from location pin holes to frontal face
  • Location holes are 2 mm NPTH
  • 13.8 mm from screw hole to frontal face. 5.1 mm to jack plug centre.
  • Screw hole is 3 mm NPTH
  • 4.2 mm from TN, RN and SN row to the jack plug center
  • Jack plug center is 7.23mm from the T, R, S row
  • Nose length is 8.9 mm

NRJ6HF-1
Compared to NRJ6HF (using diff viewer):

  • It's the same except for the SN pin being G
  • Name, description, link, etc. updated

NRJ6HF-AU
Compared to NRJ6HF (using diff viewer):

  • All the same except for the name, description, etc.

NRJ6HF-1-AU
Compared to NRJ6HF-1 (using diff viewer):

  • All the same except for the name, description, etc.

NRJ6HM-1-PRE
T, R, S, TN, RN and S. OK

Parts which require attention:

NRJ6HM-1

NRJ6HM-1-AU

  • This footprint doesn't seem to be the right one. It needs fixing.

@diegoherranz
Copy link
Collaborator

diegoherranz commented Jan 20, 2019 •
edited
Loading

Stacking jacks review

I think that all of them require some changes here:

NSJ12HC

  • Holes are 1.5mm - OK
  • 1.73 mm from G pin to frontal face - OK
  • 5.96 mm from G pin to jack plug centre - OK
  • 4.606mm from S2 (SB) and SN2 (SNB) to frontal face. Datasheet says 4.61mm. Probably not a concern given the tiny difference.
  • 7.78 mm from S1 (ST) and SN1 (SNT) to frontal face - OK
  • 10.95 mm from R2 (RB) and RN2 (RNB) to frontal face - OK
  • 14.13 mm from R1 (RT) and RN1 (RNT) to frontal face - OK
  • 17.3 mm from T2 (TB) and TN2 (TNB) to frontal face - OK
  • 20.48 mm from T1 (TT) and TN1 (TNT) to frontal face - OK
  • 7.23 mm from jack plug centre to T2 (TB), R2 (RB) and S2 (SB) - OK
  • 8.5 mm from jack plug centre to T1 (TT), R1 (RT) and S1 (ST) - OK
  • 12.7 mm pitch between Tx, Rx, Sx and TNx, RNx, SNx rows - OK
  • Airgap between G and S2 (SB) pads is ~0.144 mm. It is very common that the minimum track and gap on the cheapest PCB fabrication services is ~0.15mm (or 6 mil). I'd prefer this gap to be slightly bigger. Maybe every pad could be 2.9mm diameter (or even 2.95mm) instead of 3 mm?
  • Nose length is 8.6 mm - OK
  • Main body length is 24.3 mm - OK (offset is OK too)
  • Body width is 17mm - OK
  • The nose is 11 mm wide (diameter) but it should be 8.95mm

NSJ8HL
Compared to NSJ8HC (using diff viewer):

  • All the same except for the name, description, etc.
  • It looks OK but would require the same changes as NSJ12HC

NSJ12HL
Compared to NSJ12HC (using diff viewer):

  • All the same except for the name, description, etc.
  • It looks OK but would require the same changes as NSJ12HC
  • Other parts in this series would requiere the same changes as NSJ12HC too

@diegoherranz diegoherranz mentioned this pull request Jan 22, 2019
Open
8 tasks
@Misca1234 Misca1234 mentioned this pull request Jan 23, 2019
Merged
@evanshultz
Initial review fixes
70c8f57 
- NMJ4HCD2: link and description fixed
- NRJ6HM-1-AU like NRJ6HM-1
- Move NSJ12* pins S2 and SN2 to correct location
- NSJ8*/NSJ12* nose diameter to 8.95mm
@evanshultz
Copy link
Collaborator Author

@diegoherranz
Thanks for the in-depth review!!!

Changes:

  • NMJ4HCD2: link and description fixed
  • NRJ6HM-1-AU like NRJ6HM-1
  • Move NSJ12* pins S2 and SN2 to correct location
  • NSJ8*/NSJ12* nose diameter to 8.95mm

Open items:

  • I'll ask Neutrik about NRJ6HM-1's actual pinout since I don't have one to check. NRJ6HM-1-AU is affected as well.
  • What about making the G pin on NSJ8/NSJ12 parts 2.9mm diameter? That gives ~0.2mm air gap.

@diegoherranz
Copy link
Collaborator

What about making the G pin on NSJ8/NSJ12 parts 2.9mm diameter? That gives ~0.2mm air gap.

Happy with that 👍
I'll review the latest changes you made in the following days.
Thanks!

@gkeeth
Copy link
Contributor

gkeeth commented Mar 26, 2020

Nice, looks good. One more question: from your screenshots above, it looks like the silk is unevenly spaced from the fab line, but I think this is just a zoom/aliasing artifact, and the silk is actually fine. I'll check in kicad tonight, or if you confirm first I'm happy with that too.

Anything else I should check? I think I'm happy...

@evanshultz
Copy link
Collaborator Author

@gkeeth
Yeah, it appears to be artifacts. When zoomed in a bit things all look good to me.

@diegoherranz
You assigned this case to yourself, and Christian said he will have time to check this weekend, so would you be able to look by the end of the weekend and see if you can find anything else that needs to be done before merging?

@chschlue
Copy link
Contributor

@evanshultz Maybe I just missed it while searching the >200 comments, but how did you arrive at the board cutout widths of the *L and *R connectors? I only found information about depth so far.

@evanshultz
Copy link
Collaborator Author

@chschlue
I think you're looking for #1145 (comment) where I got info from Neutrik to confirm the flange size. I based the cutouts on that and what was already in the datasheets like this:
image

Let me know if you see a problem.

@chschlue
Copy link
Contributor

Ah. I guess I was blind.

@diegoherranz No further comments.

@evanshultz
Copy link
Collaborator Author

@diegoherranz
You assigned this case to yourself and it seems everyone else who reviewed is happy. Do you have anything further or is this ready to merge?

@chschlue
Copy link
Contributor

chschlue commented Apr 1, 2020

It think it would be nice if these made it into 5.1.6 (I assume that version and its library are going to be out in the wild for a while)

@poeschlr
Copy link
Collaborator

poeschlr commented Apr 1, 2020 •
edited
Loading

I am generally not a fan of such arguments. We should never use an arbitrary release date as a factor in what makes it into the library and what does not. Any contribution will be ready for merging exactly when both the reviewer and contributor are in agreement.

One might however argue that a maintainer could reprioritize their workload. It is however much harder to then decide if a given pull request really adds more for the user base than other pull requests under the responsivity of the same reviewer (especially when normalized to man-hours required for the review). Also remember that everyone has their own bias here (what seems important to you might be completely uninteresting to somebody else).
To be honest i would much rather leave the decision what to prioritize up to every individual reviewer (after all the personal interest of us maintainers should also be taken into account here and that is really something nobody other than us can decide).

And as a general tip for contributors: Keep pull requests small. All assets in a pull request should be highly related which most likely means they are described by the same datasheet or even better the same basic drawing. This makes it much easier to follow a discussion (as all comments are about the same thing) and also easier for other maintainers to jump in if the first reviewer does not have the time to finish their work.
In this case i think it would have been a good idea to have one pull request per connector series. (A quick guess is that this would have resulted in ten to twenty pull requests. I think this is reasonable for adding 200 footprints that are not scripted.)

I for example remember the massive review of the regulator symbol library rework. It took me a full week to work through it and a google spreadsheet to keep track of what still needs to be checked and what needs changing. After that was done i needed a long break as this single review burned me out. I do not wish this to happen to other reviewers. So to any reviewer of this: please be careful. Don't overwork yourself. If you feel tired of it, document what you did and step away for a while.

@chschlue
Copy link
Contributor

chschlue commented Apr 1, 2020

Is it possible that you didn't actually follow this thread but just ripped my last comment out of context to give that speech?

@evanshultz
Copy link
Collaborator Author

@diegoherranz
Please let me know if you find anything that needs updated.

I don't know if I read it right, but I took the comment by @chschlue above to be directed at @diegoherranz and mean something like "I reviewed this already, along with another sharp set of eyes, and believe it's ready to merge so if you're busy now you can merge and blame me or assign this PR to me for merging".

@evanshultz
Copy link
Collaborator Author

@diegoherranz
Can you please let us know if you find any issues with this PR now?

@evanshultz evanshultz mentioned this pull request Apr 19, 2020
Closed
@diegoherranz
Copy link
Collaborator

Sorry I've been absent from this PR. Let me have a look.

@evanshultz
Copy link
Collaborator Author

@diegoherranz
Ping! Are you still planning to get to this soon?

@diegoherranz
Copy link
Collaborator

Yes, I can't believe it's been a week since I said I would have a look!

@diegoherranz
Copy link
Collaborator

diegoherranz commented May 3, 2020 •
edited
Loading

Review summary

I've gone back through the history of this PR and I believe the different families have been mainly reviewed by the following people:

Thanks again for all the work on this PR, including checking dimensions which are missing or not clear in the datasheets, which is not an easy one. I think I agree with @poeschlr in that a PR for each family would be easier to handle because this PR is huge and it becomes daunting when you can only spend a short time every now and then and it's easy to lose track. But on the other hand, there are many interdependencies or things that if spotted in one PR would need to be fixed on many others, which wouldn't be easier to manage either, so swings and roundabouts.

I've checked the status of all the parts that I reviewed and they haven't been modified since my review except commits ddc7c7b and 034ba56 which modify dimensions not available in the datasheet, so I trust your discussions about it on this PR.
For the rest of families, I believe the review done by @gkeeth and @chschlue has been quite thorough, so no point in reviewing that again.

So... Merging!!

@diegoherranz diegoherranz merged commit 96e8072 into KiCad:master May 3, 2020
@diegoherranz diegoherranz removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label May 3, 2020
@gkeeth
Copy link
Contributor

gkeeth commented May 3, 2020

I feel like a single hooray emoji is not enough!

@chschlue
Copy link
Contributor

chschlue commented May 3, 2020

Don't worry, I added another one.

@antoniovazquezblanco antoniovazquezblanco removed the Enhancement Improves existing footprint in the library label May 3, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone May 3, 2020
@diegoherranz diegoherranz added the Enhancement Improves existing footprint in the library label May 3, 2020
@diegoherranz
Copy link
Collaborator

@antoniovazquezblanco, I think the enhancement label was correct because NMJ6HCD2 was improved. So I've set that label back. Feel free to remove it again if you disagree. Thanks.

@evanshultz evanshultz deleted the neutrik-jacks branch May 4, 2020 04:25
@antoniovazquezblanco
Copy link
Collaborator

Sorry, my mistake! Thank you! :)

@evanshultz
Copy link
Collaborator Author

Thanks to everybody who spent time providing feedback or other comments to get this done. @gkeeth I really appreciate the large amount of effort and and time you volunteered catching my mistakes and compiling information!!

The speakON and 1/4" connectors could have been in separate PRs. Poor planning by me. The XLRs I wanted to be grouped together. In hindsight, splitting by horizontal and vertical might have made sense but I sure didn't think to split them that way upfront.

@gkeeth
Copy link
Contributor

gkeeth commented May 5, 2020

Given the close interrelation of the XLR families, I don't think they could have been split either. That would have just split the information across multiple pull requests. The speakON and 1/4" inch connectors could have been split, yes, but it wouldn't have made much of a difference. The XLR connectors were the hairy part, and splitting out the other bits wouldn't have changed that.

I think this was going to be a big, messy job no matter what. I also don't think the pull request thread format was doing us too many favors, especially once it got so long. Next time, maybe a shared spreadsheet would help track progress and dimensions? This thought is just occurring to me now...

Anyway, thanks @evanshultz this is a huge addition to the libraries and as a user I'm super grateful.

@diegoherranz
Copy link
Collaborator

Hear hear!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@diegoherranz diegoherranz

Labels
Addition Adds new footprint to library Enhancement Improves existing footprint in the library
Projects
None yet
Milestone
5.1.6
Development

Successfully merging this pull request may close these issues.
8 participants
@evanshultz @diegoherranz @poeschlr @gkeeth @easyw @chschlue @antoniovazquezblanco @DanSGiesbrecht