Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

5.1.6 release date will be May 15th #2656

Closed
poeschlr opened this issue Apr 19, 2020 · 27 comments
Closed

5.1.6 release date will be May 15th #2656

poeschlr opened this issue Apr 19, 2020 · 27 comments

Comments

@poeschlr
Copy link
Collaborator

See source code freeze announcement https://lists.launchpad.net/kicad-developers/msg43665.html

Please add pull requests as comments that you want to be included such that we know where to focus our resources.

I personally try to get around to finally check out KiCad/kicad-footprints#1586
@chschlue
Copy link
Contributor

I usually add bugfixes and such to the next milestone to keep track.
Isn't that what we have them for?

Another question: kicad-source on GL has a 5.1.7 milestone but I couldn't find anything about another planned 5.1 release on the dev mailing list. Do you know more?

@stambaughw
Copy link
Contributor

There will most likely be a 5.1.7 release before V6 is release. We are hoping to implement the V6 feature freeze by KiCon 2020 and release by the end of the year. This will leave plenty of time to release another 5.1 branch bug fix between now and then.

@chschlue
Copy link
Contributor

This also leaves little time to migrate the libs to GL, to v6 and get rid of quite a bunch of technical debt.

@evanshultz
Copy link
Collaborator

Yeah, I would like to target resolving all known bug issues and PRs also for each release. Status now:

Note that some of the symbol items are meant for the next major release. Some didn't have a milestone assigned and I didn't take the time to look at each one.

@poeschlr is there more work to be done at KiCad/kicad-footprints#1410? It's unclear if this has been resolved as there is only one linked PR and it was merged.

KiCad/kicad-footprints#2166 is a bug, I guess, though it's not marked as one. But it's minor and should be easy.

KiCad/kicad-footprints#1076 is a very nice addition that I would like to see added. There have been users asking about DIN 41612 footprints and other handmade PRs for them so it seems to me the community would like these footprints merged as well. Once that's done we'll have to look at symbols...

And I selfishly would like to see KiCad/kicad-footprints#1145 get merged. @diegoherranz has posted a few times lately so perhaps we will get an update soon if this PR is ready or if someone else should take it over?

@diegoherranz
Copy link
Collaborator

And I selfishly would like to see KiCad/kicad-footprints#1145 get merged. @diegoherranz has posted a few times lately so perhaps we will get an update soon if this PR is ready or if someone else should take it over?

Let me have a look at KiCad/kicad-footprints#1145. I should have some time now.

@evanshultz
Copy link
Collaborator

@poeschlr
I also consider pointhi/kicad-footprint-generator#438 to be a bug. We are claiming IPC7351 footprints, using IPC-SM-782 size definitions where available, but I found that R, L, and C parts have different body sizes which the generator was assuming they were all the same. If you could check the script and confirm the changes are OK, I will resolve conflicts on that script PR and submit the updated footprints. I really wanted your eyes on the script first.

@poeschlr
Copy link
Collaborator Author

poeschlr commented Apr 24, 2020 •
edited
Loading

@evanshultz i think the EP size stuff has not yet been started at all. A few footprints will therefore still have the wrong sizes. (Wrong in the sense that they use the maximum size of the datasheet but the size agrees with the footprint name so the user sees it easily)

@chschlue
Copy link
Contributor

I think KiCad/kicad-footprints#2072 would be ready to go if it weren't for pointhi/kicad-footprint-generator#474.
@poeschlr since you merged that one, what are we going to do with it? (see also KiCad/kicad-footprints#2072 (comment))

@poeschlr
Copy link
Collaborator Author

I introduced a minor fix for unifying the pin 1 markers of DFN footprints KiCad/kicad-footprints#2244

@poeschlr
Copy link
Collaborator Author

@evanshultz your script changes for differentiating R/L/C sizes is generally ok. However, a final verdict requires checking if only the intended footprints change when running the script. (Which means a footprint pull request is required)

@poeschlr
Copy link
Collaborator Author

poeschlr commented Apr 26, 2020 •
edited
Loading

Oh and if i can be selfish, i would like the solder wire stuff (KiCad/kicad-footprints#2062) to be merged soon as it would allow me to simplify two tutorials on the forum. At least feedback on the open questions would be appreciated.

@evanshultz
Copy link
Collaborator

KiCad/kicad-footprints#2244 has been merged.

@poeschlr
I left comments at pointhi/kicad-footprint-generator#438 and, once those are resolved, will make a footprint PR. Thanks for taking a look at that one!

@chschlue
Copy link
Contributor

chschlue commented May 9, 2020 •
edited
Loading

State of the libs with a week to go:
https://github.com/KiCad/kicad-symbols/milestone/11 8 open, 1 unassigned, 1 assignee possibly inactive
https://github.com/KiCad/kicad-footprints/milestone/7 10 open, 3 unassigned, 1 assignee possibly inactive
https://github.com/KiCad/kicad-footprints/milestone/7 8 open, 1 unassigned, 1 assignee possibly inactive
https://github.com/KiCad/kicad-packages3D/milestone/6 0 open
https://github.com/KiCad/kicad-templates/milestone/5 1 open, 1 unassigned

(I added everything mentioned here so far to these milestones and selfishly added KiCad/kicad-templates#29, which isn't terribly urgent but should be easy to review (if you happen to have a particular skillset @poeschlr @cpresser))

Templates seem to be our red-headed stepchildren...

@poeschlr
Copy link
Collaborator Author

poeschlr commented May 11, 2020 •
edited
Loading

Yesterday @stambaughw posted to the mailing list that everything shall be tagged by today such that the packagers have a week to get everything done. I will now check the symbol libs for problems and if there are no major design breaking changes then i will create the tag.
The remaining issues will have to wait for 5.1.7 or for version 6 depending on how exactly we decide to handle the next few months.

Sorry for not communicating this earlier, I had no time for KiCad the last few hours (i just now read the mailing message, i forgot that Friday is the release date not the tag date.)

@chschlue
Copy link
Contributor

@poeschlr please give me a couple minutes to check something that just came up today.

@poeschlr
Copy link
Collaborator Author

poeschlr commented May 11, 2020 •
edited
Loading

Is ok, just ping me (i will still check what we have so far, your change will hopefully not fully change the lib)
Also technically we have until midnight ;) (and who says we need to use CET here)

@chschlue
Copy link
Contributor

chschlue commented May 11, 2020 •
edited
Loading

Not a huge deal, really. Just #2718.
After #2539 got merged, #2708 which adds the rest of the family brought up that one symbol was named wrong.
Would be a pity if we we were stuck with if it's released, that's all.

@chschlue
Copy link
Contributor

Sry, ping @poeschlr

@chschlue
Copy link
Contributor

Also technically we have until midnight ;) (and who says we need to use CET here)

I would always assume UTC if no timezone is given. We probably even have until the early morning, @stambaughw's midnight is pretty late, I think ;)

@poeschlr
Copy link
Collaborator Author

poeschlr commented May 11, 2020 •
edited
Loading

Analysis of Symbol lib

Removed (or renamed) symbols

Wrongly reported as removed

  • power.lib:~Earth
  • power.lib:~Earth_Clean
  • power.lib:~Earth_Protective

For these the ~ was removed. I am not sure what that change exactly means. See PR #2592

Pins have been moved, renumbered or removed in symbol

Normal pins ok but NC pins have been moved, renumbered or removed in symbol

  • Converter_ACDC.lib:IRM-03-3.3 and its aliases IRM-03-5, IRM-03-12, IRM-03-15, IRM-03-24

Full changelog
5.1.6_vs_5.1.5.txt
5.1.6_vs_5.1.5.log

@evanshultz
Copy link
Collaborator

evanshultz commented May 11, 2020 •
edited
Loading

The 'Wrongly reported as removed' section is OK. See comments in the PR.

I feel it's a shame that we now have nice DIN 41612 footprints but not corresponding symbols. If the library can wait to be tagged for 24 hours I will plan to generate them by then.

Also, I would really like to get pointhi/kicad-footprint-generator#438 merged since it's a bug, IMO, but I haven't had time to try and figure out how to untangle things.

Edit: I will also take care of #2710.

@poeschlr
Copy link
Collaborator Author

poeschlr commented May 11, 2020 •
edited
Loading

There will always be things that would be nice to get in especially shortly before a release. There will be future releases so the work will not be lost ;)
I will try to help you with untangling the footprint generator fixes sometime this week. Depends a bit how stressful work is. (One of my "responsibilities" at work is to fixup git problems of others so i have gotten a lot of experience lately)

Edit: also i had already tagged the lib when i read your response

@nickoe
Copy link
Contributor

nickoe commented May 11, 2020

@poeschlr If you think some hints are needed for the release announcement about the library, please add them to https://github.com/KiCad/kicad-website/blob/master/content/blog/release-5.1.6.adoc

@stambaughw
Copy link
Contributor

stambaughw commented May 11, 2020 via email

@poeschlr
Copy link
Collaborator Author

poeschlr commented May 11, 2020 •
edited
Loading

@nickoe if you want you can link to the diff logs i also link in the release page (for symbols only). But i am not aware that we did that for past releases.

Edit: The release link https://github.com/KiCad/kicad-symbols/releases/tag/5.1.6

@nickoe
Copy link
Contributor

nickoe commented May 11, 2020

@poeschlr We have done it for some. If you (the librarians) want to and have something semiautomated it could make sense to show it at every release. For example in https://kicad-pcb.org/blog/2017/03/KiCad-4.0.6-Stable-Release/ we listed some renames... If you don't think it makes sense in this case, we will just stick with the generic point release format as we have now.

@nickoe
Copy link
Contributor

nickoe commented May 12, 2020

@poeschlr @cpresser Related to this is https://lists.launchpad.net/kicad-developers/msg43785.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@diegoherranz @nickoe @evanshultz @stambaughw @poeschlr @chschlue