This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myfreescalewebpage
added
Enhancement
Improves existing footprint in the library
Pending reviewer
A pull request waiting for a reviewer
labels
Mar 23, 2020
chschlue
added
Bug
Fix footprint existing in the library
and removed
Pending reviewer
A pull request waiting for a reviewer
labels
Apr 19, 2020
chschlue
suggested changes
Apr 19, 2020
- Correct one 30.22 fab line to horizontal - Make 30.22 fab layer bevel exactly 1mm - All fab lines now 0.1mm wide - 30.22 silk lines now 0.11mm from fab lines and pin 1 silk mark 0.25mm from other silk lines
Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple minor issues with some relay footprints.
Finder 30.22
https://www.finder-relais.net/en/finder-relays-series-30.pdf
Before (left fab line was not vertical):
After:
I didn't rotate this one since the pins names didn't include
1
and I'm fixing the issue I found and plan to stop at that.Omron G5V-2
https://omronfs.omron.com/en_US/ecb/products/pdf/en-g5v2.pdf
Before (line sticking down at the bottom left, but I also noticed that the body dimensions and a few pins weren't in the right place and I moved the text while I was at it):
After:
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)