Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix relays #2166

Merged
merged 10 commits into from
Apr 21, 2020
Merged

Fix relays #2166

merged 10 commits into from
Apr 21, 2020

Conversation

evanshultz
Copy link
Collaborator

I noticed a couple minor issues with some relay footprints.

Finder 30.22
https://www.finder-relais.net/en/finder-relays-series-30.pdf
Before (left fab line was not vertical):
image
After:
image

I didn't rotate this one since the pins names didn't include 1 and I'm fixing the issue I found and plan to stop at that.

Omron G5V-2
https://omronfs.omron.com/en_US/ecb/products/pdf/en-g5v2.pdf
Before (line sticking down at the bottom left, but I also noticed that the body dimensions and a few pins weren't in the right place and I moved the text while I was at it):
image
After:
image
image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing footprint in the library Pending reviewer A pull request waiting for a reviewer labels Mar 23, 2020
@chschlue chschlue self-assigned this Apr 19, 2020
@chschlue chschlue added Bug Fix footprint existing in the library and removed Pending reviewer A pull request waiting for a reviewer labels Apr 19, 2020
@chschlue chschlue added this to the 5.1.6 milestone Apr 19, 2020
@evanshultz
Copy link
Collaborator Author

Thanks for looking!

Right you are. Thank you. I fixed that and moved the bevel to exactly 1mm since the fab lines no longer closed. But that revealed the fab lines were 0.12mm so I slimmed them all down to 0.1mm. Then the silk obviously wasn't evenly offset from the fab lines, so I made them all 0.11mm away.
image

I also corrected the fab line width on teh G5V-2 footprint as well.

- Correct one 30.22 fab line to horizontal
- Make 30.22 fab layer bevel exactly 1mm
- All fab lines now 0.1mm wide
- 30.22 silk lines now 0.11mm from fab lines and pin 1 silk mark 0.25mm from other silk lines
@chschlue
Copy link
Contributor

Thanks.

@chschlue chschlue merged commit 84f05ca into KiCad:master Apr 21, 2020
@evanshultz evanshultz deleted the fix-relays branch April 21, 2020 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix footprint existing in the library Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants