Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix EFM8BB10F8G-A-QFN20 default FP #2545

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Conversation

chschlue
Copy link
Contributor

@chschlue chschlue commented Mar 14, 2020

see KiCad/kicad-footprints#1989
depends on KiCad/kicad-footprints#2139


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@chschlue chschlue added the Bug Fix symbol existing in the library label Mar 14, 2020
chschlue added a commit to chschlue/kicad-footprints that referenced this pull request Mar 14, 2020
chschlue added a commit to chschlue/kicad-footprints that referenced this pull request Mar 14, 2020
chschlue added a commit to chschlue/kicad-footprints that referenced this pull request Mar 14, 2020
@chschlue chschlue added this to the 5.1.6 milestone Mar 14, 2020
@cpresser
Copy link
Contributor

While you are at it, can you please fix the pin-name-position-offset?
How about also changing the GND pins to be stacked. That won't break existing schematics, just make them look ugly.

@chschlue
Copy link
Contributor Author

Done.

@cpresser cpresser added the Pending footprint Pending footprint acceptance before merging label Mar 15, 2020
@myfreescalewebpage myfreescalewebpage added the Pending reviewer A pull request waiting for a reviewer label Mar 15, 2020
@cpresser cpresser self-assigned this Mar 16, 2020
@cpresser cpresser removed the Pending reviewer A pull request waiting for a reviewer label Mar 16, 2020
chmorgan pushed a commit to KiCad/kicad-footprints that referenced this pull request Mar 17, 2020
@chschlue
Copy link
Contributor Author

@cpresser FP changes have been merged.

@cpresser cpresser merged commit c913697 into KiCad:master Mar 17, 2020
@cpresser cpresser removed the Pending footprint Pending footprint acceptance before merging label Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix symbol existing in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants