Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

fix symbol to match footprint pr #2659

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Apr 20, 2020

Modifies the SE5004L rf amp to match the proposed footprint PR.

se5004l-sch


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer Enhancement Improves existing symbol in the library and removed Addition Adds new symbols to library labels Apr 21, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Apr 26, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Apr 26, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Apr 26, 2020

Hi @matthuszagh thanks for this fixes,

Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Apr 26, 2020
@matthuszagh
Copy link
Contributor Author

Hey @myfreescalewebpage thanks for the review. Pin 1 etc and EP are connected. Check the land pattern in the first image of the footprint PR I referenced (taken from the datasheet). Let me know if any further concerns, I'll update the datasheet link.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Apr 28, 2020

I have seen you connected them on the footprint. But I refer to the datasheet. Why connecting these pins together ?

The question is for both the symbol and the footprint :)

@matthuszagh
Copy link
Contributor Author

matthuszagh commented Apr 28, 2020

I'm referring to the datasheet too, which is what I was discussing in my last comment. I'll post the image from the datasheet again (page 7).

77214172-0a2f5180-6acb-11ea-8829-13153744247d

That first image on the left is the land pattern. As you can see, the EP and all ground pins are connected together. In order for the symbol to match this footprint, EP and ground must be connected.

Does this make sense, or am I missing your point?

@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label Apr 28, 2020
@myfreescalewebpage
Copy link
Collaborator

No worry, I haven't checked the footprint in the datasheet, only the description of pins.
The symbol is not broken, so no need to wait V6, and I don't anything which need the footprint to be merged first.
Can you update the datasheet link first ?
Thanks,
Joel

@matthuszagh
Copy link
Contributor Author

Datasheet updated.

@myfreescalewebpage
Copy link
Collaborator

Thanks, no more comment, merging.

@myfreescalewebpage myfreescalewebpage merged commit ab409fb into KiCad:master Apr 28, 2020
@matthuszagh matthuszagh deleted the se5004l_pins branch April 28, 2020 21:06
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants