This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Fix Pin 1 Markers to fit with KLC (IPC suggestion) #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pointhi/kicad-footprint-generator#278 for DFN footprints
poeschlr
added
Enhancement
|
Took a quick look at the diff and CI. Nothing jumped out at me. If there are issues from this it will still likely be better for users and we can deal with it later. Thank you, Rene! |
myfreescalewebpage
removed
the
Pending reviewer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pointhi/kicad-footprint-generator#278 for DFN footprints
This is a manual fix to unify all Pin 1 markers to fit with KLC (IPC). The pull request only touches silk and fab outlines (fab only where the chamfer was way too large).
Edit: I do not intend to fix any of the other KLC issues in these.