Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Make 555 timers fully specified #2429

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Conversation

poeschlr
Copy link
Collaborator

@poeschlr poeschlr commented Jan 7, 2020

  • Split the original symbol into one per package
  • Renamed symbols (and aliases) to include the package suffix
  • Cleaned up documentation and keywords

This is a design breaking change I am however quite sure it is worth it. Especially as some of the old aliases already had the package suffix there but were assigned to a symbol that was generic. Plus the footprint filters used in that symbol did not fit all aliases.

Summary of the symbols we had in some form in the lib with their packages and relevant part numbers plus datasheets.
https://docs.google.com/spreadsheets/d/1VMY6TS7239a-nVVFeL2KGmgWQvnMle-uqJrocWEhT4M/edit?usp=sharing

@poeschlr poeschlr added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Jan 7, 2020
- Split the original symbol into one per package
- Renamed symbols (and aliases) to include the package suffix
- Cleaned up documentation and keywords
@evanshultz evanshultz self-assigned this Jan 8, 2020
@evanshultz
Copy link
Collaborator

  1. Usually I recall seeing the package show DIP and not PDIP, but that's fine.
  2. Why not use the LM555 datasheet for LM555CMM instead of the NE555 datasheet?
  3. LM555 is not wildcarding the temp like LMC555.
  4. Missing , 555 compatible in LMC555xTP and TLC555xPW descriptions.
  5. I believe NA555, SA555, and SE555 are high-temp or specially-qualified variants of NE555 so should they be removed or wildcarded not kept as individual ALIASes?
  6. NE555P mentions a SOIC package but it's DIP.
  7. TLC555xPW says VSSOP in the description but the datasheet calls it TSSOP. While we seem to only have a fitting footprint named VSSOP, I don't see why the description can't match the datasheet package name and if I was looking at the datasheet and the description it would be nice to match.

@poeschlr
Copy link
Collaborator Author

@evanshultz fixed what needed fixing and answered the remaining questions below:


Usually I recall seeing the package show DIP and not PDIP, but that's fine.

I used PDIP because this is what is used in the datasheets (and it also explains why most of them use the suffix P)

Missing , 555 compatible in LMC555xTP and TLC555xPW descriptions.

These two are in unusual packages (for 555) so i did not add the compatibility text.

I believe NA555, SA555, and SE555 are high-temp or specially-qualified variants of NE555 so should they be removed or wildcarded not kept as individual ALIASes?

Not all of them are available in the same packages so it would get quite complex to wildcard them.

TLC555xPW says VSSOP in the description but the datasheet calls it TSSOP. While we seem to only have a fitting footprint named VSSOP, I don't see why the description can't match the datasheet package name and if I was looking at the datasheet and the description it would be nice to match.

Are you sure? It is connected to Package_SO:TSSOP-14_4.4x5mm_P0.65mm and uses TSSOP in the description.

@evanshultz
Copy link
Collaborator

Either it looks good or I got confused (the last one). Thanks!

@evanshultz evanshultz merged commit d67d883 into KiCad:master Jan 13, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Jan 13, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Jan 14, 2020
jamesrlucas pushed a commit to jamesrlucas/kicad-symbols that referenced this pull request Apr 20, 2020
* Make 555 timers fully specified

- Split the original symbol into one per package
- Renamed symbols (and aliases) to include the package suffix
- Cleaned up documentation and keywords

* Fixes as requested
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants