Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Adding JK0654219NL #1886

Merged
merged 5 commits into from
Oct 19, 2019
Merged

Adding JK0654219NL #1886

merged 5 commits into from
Oct 19, 2019

Conversation

ki5libs
Copy link
Contributor

@ki5libs ki5libs commented Oct 3, 2019

Adding JK0654219NL
Datasheet

JK0654219NL_footprint


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Oct 5, 2019
@gmsotavio gmsotavio self-assigned this Oct 14, 2019
@gmsotavio gmsotavio removed the Pending reviewer A pull request waiting for a reviewer label Oct 14, 2019
@gmsotavio
Copy link
Collaborator

gmsotavio commented Oct 14, 2019

Hi. Thanks for your contribution.

I have a question and some notes about your footprint.

Which symbol do you intend to use with this footprint?

  • Please, provide a description in the "Description" field. Currently, there is a datasheet link only. If available, replace the datasheet link from DigiKey by the link provided by the manufacturer.

image

  • The Silk lines are too near to the exposed copper of the pads. Clearance between silkscreen and exposed copper elements is recommended to be 0.2mm (at least), as per KLC F5.1 (http://kicad-pcb.org/libraries/klc/F5.1/).
    image

  • I suggest keeping the Fab outline continuous
    image

  • Pin-1 indicator is missing on the Fab layer.
    image
    I recommend something like this
    image

  • There are a few wrong dimensions. Take a look at the dimensioned drawing bellow. (Blue dimension lines are in inches and pink in mm. Red text means a bad dimension).
    image

image

@ki5libs
Copy link
Contributor Author

ki5libs commented Oct 14, 2019

Hi @gmsotavio
This footprint going to be used with this symbol

  • description added, couldn't find this part on the manufacturer website, so old link left;
  • silk and fab lines are corrected;
  • pin-1 indicator added on Fab layer;
  • dimensions are fixed

@gmsotavio gmsotavio added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Oct 14, 2019
@gmsotavio
Copy link
Collaborator

gmsotavio commented Oct 14, 2019

Hi @ki5libs,

Thanks for addressing all my suggestions.

  • One incorrect dimension remains. Take a look at the dimensioned drawing.

image

@gmsotavio gmsotavio added Pending changes and removed Ready for review Use this to mark pull requests that are updated but you could not review instantly labels Oct 14, 2019
@ki5libs
Copy link
Contributor Author

ki5libs commented Oct 15, 2019

Hi @gmsotavio

looks like it happened because I use metric dimensions. It should be OK now. Thanks for review.

@gmsotavio gmsotavio added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Oct 15, 2019
@gmsotavio
Copy link
Collaborator

gmsotavio commented Oct 18, 2019

100%. Thanks.

image

@gmsotavio gmsotavio removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Oct 18, 2019
@gmsotavio gmsotavio merged commit 3e4d396 into KiCad:master Oct 19, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants