Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Adding JK0654219NL #2228

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Adding JK0654219NL #2228

merged 2 commits into from
Oct 19, 2019

Conversation

ki5libs
Copy link
Contributor

@ki5libs ki5libs commented Oct 3, 2019

Adding JK0654219NL
Datasheet

JK0654219NL

Footprint PR


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@cpresser cpresser added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Oct 5, 2019
@gmsotavio gmsotavio removed the Pending reviewer A pull request waiting for a reviewer label Oct 14, 2019
@gmsotavio gmsotavio self-assigned this Oct 14, 2019
@gmsotavio
Copy link
Collaborator

gmsotavio commented Oct 18, 2019

Hi @ki5libs,

Thanks for your contribution, by the way, it's a nice symbol. Some notes about it.

Please, provide a screenshot of your symbol after provide the changes.

@gmsotavio gmsotavio added the Pending changes User is expected to perform fixes before merging label Oct 18, 2019
@ki5libs
Copy link
Contributor Author

ki5libs commented Oct 19, 2019

Hi @gmsotavio,

thanks for review. All changes you asked are done. This is changed symbol screenshot

JK0654219NL_new

@gmsotavio gmsotavio closed this Oct 19, 2019
@gmsotavio gmsotavio reopened this Oct 19, 2019
@gmsotavio
Copy link
Collaborator

gmsotavio commented Oct 19, 2019

Closing and reopening to force Travis script to run again.

@gmsotavio
Copy link
Collaborator

Great. Thank you for your contribution to KiCad libraries and for addressing my suggestions.

Regards,

@gmsotavio gmsotavio merged commit af8c9ee into KiCad:master Oct 19, 2019
@gmsotavio gmsotavio removed the Pending changes User is expected to perform fixes before merging label Oct 19, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants