Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

WLCSP-4-X1-WLB0909-4_0.890x0.890_P0.500mm #2364

Merged
merged 2 commits into from
Sep 30, 2020
Merged

WLCSP-4-X1-WLB0909-4_0.890x0.890_P0.500mm #2364

merged 2 commits into from
Sep 30, 2020

Conversation

chmorgan
Copy link
Collaborator

@chmorgan chmorgan commented Jul 18, 2020

Footprint for a number of OnSemi power switches.

Generator PR: pointhi/kicad-footprint-generator#575

image

https://www.diodes.com/assets/Datasheets/AP22913.pdf


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jul 21, 2020
@cpresser
Copy link
Contributor

Is there a matching footprint-generator script and PR?

@chmorgan
Copy link
Collaborator Author

@cpresser added footprint generator PR above in the first comment, sorry about missing that.

It's at pointhi/kicad-footprint-generator#575 if you don't want to scroll up.

@chmorgan
Copy link
Collaborator Author

@cpresser and here is the updated footprint after I removed a couple of extra fields in the footprint generator side that I learned about during previous footprint generator reviews.

@myfreescalewebpage
Copy link
Collaborator

@cpresser I assigned you to this PR because you self assigned to the PR of the generator associated to this footprint

@cpresser
Copy link
Contributor

@chmorgan Can you please push the generator result here? I expect the name to change slightly.

@myfreescalewebpage
Copy link
Collaborator

@chmorgan ping

@chmorgan
Copy link
Collaborator Author

chmorgan commented Sep 30, 2020

@myfreescalewebpage @cpresser updated from generator, renamed from old name. Sorry for the delay and I really appreciate the review.

@myfreescalewebpage myfreescalewebpage self-assigned this Sep 30, 2020
@myfreescalewebpage
Copy link
Collaborator

Helping here, footprint is ok for me, merging.

@myfreescalewebpage myfreescalewebpage merged commit 7953bad into KiCad:master Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants