Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

csp.yaml - Add X1-WLB0909 footprint #575

Merged
merged 2 commits into from
Sep 25, 2020
Merged

csp.yaml - Add X1-WLB0909 footprint #575

merged 2 commits into from
Sep 25, 2020

Conversation

chmorgan
Copy link
Contributor

@codeclimate
Copy link

codeclimate bot commented Jul 15, 2020 •
edited
Loading

Code Climate has analyzed commit 7993427 and detected 0 issues on this pull request.

View more on Code Climate.

@chmorgan chmorgan mentioned this pull request Sep 20, 2020
Merged
5 tasks
cpresser
cpresser reviewed Sep 22, 2020
View reviewed changes
scripts/Packages/Package_BGA/csp.yaml Outdated
body_size_y: 0.890
pitch: 0.500
pad_diameter: 0.235
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was bamboozeled here first and wanted to complain that pad_ and ball_diameter are not the same.
But analog recommends to use 0.235 for the landing pad as well. So I guess its fine.

Please add a comment explaining that (please replace with better wording - I am not a native speaker).
# ball_diameter is 0.235, the recommended landing pad from analog is also 0.235. Don't be bamboozeled

scripts/Packages/Package_BGA/csp.yaml Outdated
layout_y: 4
WLCSP-4-X1-WLB0909-4_0.890x0.890_P0.500mm:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mm is missing from the xy-size. Also the trailing zero on 0.890 could be removed.

@cpresser cpresser self-assigned this Sep 22, 2020
@cpresser
Copy link
Collaborator

Thanks, looks good.
Next time, please don't force-push so I can easier review changes. In this case it was not an issue since its only a few lines though.

@cpresser cpresser merged commit c5045d1 into pointhi:master Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpresser cpresser cpresser approved these changes

Assignees

@cpresser cpresser

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chmorgan @cpresser