-
Notifications
You must be signed in to change notification settings - Fork 712
Add script generated HVQFN-32-1EP_5x5mm_P0.5mm_EP3.1x3.1mm #2439
Conversation
Can you please add a link to the script? I would like to review that. |
@cpresser This looks like it's been made using Modedit's FP generator. @Kev-J please script this using https://github.com/pointhi/kicad-footprint-generator/tree/master/scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON |
In fact I used the KiCAD built-in tool to generate this. Wasn't it the good way to do? Edit: My bad, I thought the process was the same as for symbols. I got it now :) May I suggest to add a checkbox in the PR template like "paste the script if the package is requiring it" |
@chschlue thanks for the hint. I will do a PR on the kicad-footprint-generator to add this piece of yaml:
Does it look good to you? Cheers, |
No, you could not know. Afaik it is nowhere documented. Which is bad. The 'correct' approch is to open a PR in the footprints-generator repo that adds the .yaml changes. So we can recreate those footprints later if required. |
Ok, you can find the PR right here: pointhi/kicad-footprint-generator#629 |
@chschlue This is a duplicate of |
Sadly, the current approach is to add duplicates if manufacturer naming differs (as in this case). |
@cpresser do you want to review this one ? Else tell me I will do it |
Thanks for the reminder @myfreescalewebpage |
Hi, this HVQFN footprint was necessary for my symbol of the PN512 (KiCad/kicad-symbols#2884)
Datasheet: https://www.nxp.com/docs/en/package-information/SOT617-1.pdf
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)