Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added PN512 RFID module #2884

Merged
merged 5 commits into from
Sep 22, 2020
Merged

Conversation

Kev-J
Copy link
Contributor

@Kev-J Kev-J commented Jul 29, 2020

Hi,

I just created the symbol for the PN512 RFID module.
Associated footprint: KiCad/kicad-footprints#2439
Datasheet: https://www.nxp.com/docs/en/data-sheet/PN512.pdf
Sans titre

Cheers,
Kevin

@Kev-J Kev-J force-pushed the add-pn512-rfid branch 3 times, most recently from 887ae00 to 7f397d5 Compare July 29, 2020 08:19
@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Aug 2, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 25, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 25, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 25, 2020

Hi @Kev-J , thanks for contributing,

A few comments I have during my review:

  • Description should ends with package name and should not have specific symbols: NFC frontend, ISO/IEC 14443A&B, MIFARE, FeliCa and NFC Forum tag types, HVQFN-32 is great
  • Footprint should be HVQFN, not QFN. If it does not exists you should submit it.
  • Fp filter will be HVQFN*1EP*5x5mm*P0.5mm*
  • You should align DVDD with DVSS, PVDD with PVSS etc
  • Name of pin 6 should be ~NRSTPD
  • I don't see where pin 33 is connected to PVSS in the datasheet. Should be called "EP", Passive, and not stacked with PVSS
  • You should stack TVSS pins
  • The global dimensions of the symbol can be reduced a lot, please

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Aug 25, 2020
@Kev-J
Copy link
Contributor Author

Kev-J commented Aug 31, 2020

Hi Joel,

It should be better now. I updated the PR's first message to link with the footprint's PR.
I still have one error (except the missing footprint) about the TVSS pin stack. Do you want me to turn one pin into invisible and passive?

cheers,
Kevin

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 1, 2020

Thanks for the update.

Do you want me to turn one pin into invisible and passive?

Yes one of the two should be Passive Invisible to respect stacking rule.

One comment also:

  • EP is no more stacked, so it should be visible now

Joel

@Kev-J
Copy link
Contributor Author

Kev-J commented Sep 2, 2020

Done 👍

Thanks a lot,
Kevin

@myfreescalewebpage
Copy link
Collaborator

Thanks, just need to wait the footprint.

@cpresser
Copy link
Contributor

This is yet another instance where the footprint is just a copy of an existing one.
See pointhi/kicad-footprint-generator#629 (comment)

@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label Sep 22, 2020
@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage
Copy link
Collaborator

Merging the symbol following the footprint

@myfreescalewebpage myfreescalewebpage merged commit 0017da1 into KiCad:master Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants