-
Notifications
You must be signed in to change notification settings - Fork 710
Conversation
Whoa!?!?!? The footprint was added at #129, and removed with #469 (I assume accidentally when other chip-size footprints were updated). Is that what you were seeing? @poeschlr @Shackmeister Do you want to add reverse mount LEDs to the script? @fauxpark |
Yeah, I'm guessing it was removed because it now didn't match the scripted footprints. I don't see any other reverse mount LED packages apart from some oddball sizes that aren't scripted anyway. I also pulled back the inner sides of the pads slightly to accommodate the hole. An oval hole would fit both the circular and square lenses, but I can make another footprint with a square hole if need be. |
It was removed by accident. When i changed the pad size calculation i needed to delete the handsolder versions as they include the pad size in their name. |
Speaking of which, I just noticed the _HandSolder diodes and LEDs look exactly the same as the normal footprints. SMD caps and resistors are not. Is that intentional? |
The Handsolder version has slightly longer pads. (The toe side is elongated.) More detailed: right now the Zmax dimension (outside to outside between both pads) is increased by 0.35mm compared to the normal footprint. This means each pad is longer by 0.35/2 = 0.175mm. Originally i determined this value by taking my own footprints that i regularly handsolder and looked how much larger their pads are when compared to the ipc suggestion. If somebody thinks this size increase is too small i can of course change that value. (I would not increase it by too much.) |
That's not what I'm seeing: --- /Users/fauxpark/Git/kicad-footprints/Diode_SMD.pretty/D_0603_1608Metric.kicad_mod Thu Jun 28 21:05:39 2018
+++ /Users/fauxpark/Git/kicad-footprints/Diode_SMD.pretty/D_0603_1608Metric_Pad0.88x0.95mm_HandSolder.kicad_mod Thu Jun 28 21:05:39 2018
@@ -1,11 +1,11 @@
-(module D_0603_1608Metric (layer F.Cu) (tedit 5B301BBE)
+(module D_0603_1608Metric_Pad0.88x0.95mm_HandSolder (layer F.Cu) (tedit 5B301BBE)
(descr "Diode SMD 0603 (1608 Metric), square (rectangular) end terminal, IPC_7351 nominal, (Body size source: http://www.tortai-tech.com/upload/download/2011102023233369053.pdf), generated with kicad-footprint-generator")
- (tags diode)
+ (tags "diode handsolder")
(attr smd)
(fp_text reference REF** (at 0 -1.43) (layer F.SilkS)
(effects (font (size 1 1) (thickness 0.15)))
)
- (fp_text value D_0603_1608Metric (at 0 1.43) (layer F.Fab)
+ (fp_text value D_0603_1608Metric_Pad0.88x0.95mm_HandSolder (at 0 1.43) (layer F.Fab)
(effects (font (size 1 1) (thickness 0.15)))
)
(fp_line (start 0.8 -0.4) (end -0.5 -0.4) (layer F.Fab) (width 0.1))
Versus: --- /Users/fauxpark/Git/kicad-footprints/Capacitor_SMD.pretty/C_0603_1608Metric.kicad_mod Thu Jun 28 21:05:39 2018
+++ /Users/fauxpark/Git/kicad-footprints/Capacitor_SMD.pretty/C_0603_1608Metric_Pad1.05x0.95mm_HandSolder.kicad_mod Thu Jun 28 21:05:39 2018
@@ -1,25 +1,25 @@
-(module C_0603_1608Metric (layer F.Cu) (tedit 5B301BBE)
- (descr "Capacitor SMD 0603 (1608 Metric), square (rectangular) end terminal, IPC_7351 nominal, (Body size source: http://www.tortai-tech.com/upload/download/2011102023233369053.pdf), generated with kicad-footprint-generator")
- (tags capacitor)
+(module C_0603_1608Metric_Pad1.05x0.95mm_HandSolder (layer F.Cu) (tedit 5B301BBE)
+ (descr "Capacitor SMD 0603 (1608 Metric), square (rectangular) end terminal, IPC_7351 nominal with elongated pad for handsoldering. (Body size source: http://www.tortai-tech.com/upload/download/2011102023233369053.pdf), generated with kicad-footprint-generator")
+ (tags "capacitor handsolder")
(attr smd)
(fp_text reference REF** (at 0 -1.43) (layer F.SilkS)
(effects (font (size 1 1) (thickness 0.15)))
)
- (fp_text value C_0603_1608Metric (at 0 1.43) (layer F.Fab)
+ (fp_text value C_0603_1608Metric_Pad1.05x0.95mm_HandSolder (at 0 1.43) (layer F.Fab)
(effects (font (size 1 1) (thickness 0.15)))
)
(fp_line (start -0.8 0.4) (end -0.8 -0.4) (layer F.Fab) (width 0.1))
(fp_line (start -0.8 -0.4) (end 0.8 -0.4) (layer F.Fab) (width 0.1))
(fp_line (start 0.8 -0.4) (end 0.8 0.4) (layer F.Fab) (width 0.1))
(fp_line (start 0.8 0.4) (end -0.8 0.4) (layer F.Fab) (width 0.1))
- (fp_line (start -0.162779 -0.51) (end 0.162779 -0.51) (layer F.SilkS) (width 0.12))
- (fp_line (start -0.162779 0.51) (end 0.162779 0.51) (layer F.SilkS) (width 0.12))
- (fp_line (start -1.48 0.73) (end -1.48 -0.73) (layer F.CrtYd) (width 0.05))
- (fp_line (start -1.48 -0.73) (end 1.48 -0.73) (layer F.CrtYd) (width 0.05))
- (fp_line (start 1.48 -0.73) (end 1.48 0.73) (layer F.CrtYd) (width 0.05))
- (fp_line (start 1.48 0.73) (end -1.48 0.73) (layer F.CrtYd) (width 0.05))
- (pad 1 smd roundrect (at -0.7875 0) (size 0.875 0.95) (layers F.Cu F.Mask F.Paste) (roundrect_rratio 0.25))
- (pad 2 smd roundrect (at 0.7875 0) (size 0.875 0.95) (layers F.Cu F.Mask F.Paste) (roundrect_rratio 0.25))
+ (fp_line (start -0.171267 -0.51) (end 0.171267 -0.51) (layer F.SilkS) (width 0.12))
+ (fp_line (start -0.171267 0.51) (end 0.171267 0.51) (layer F.SilkS) (width 0.12))
+ (fp_line (start -1.65 0.73) (end -1.65 -0.73) (layer F.CrtYd) (width 0.05))
+ (fp_line (start -1.65 -0.73) (end 1.65 -0.73) (layer F.CrtYd) (width 0.05))
+ (fp_line (start 1.65 -0.73) (end 1.65 0.73) (layer F.CrtYd) (width 0.05))
+ (fp_line (start 1.65 0.73) (end -1.65 0.73) (layer F.CrtYd) (width 0.05))
+ (pad 1 smd roundrect (at -0.875 0) (size 1.05 0.95) (layers F.Cu F.Mask F.Paste) (roundrect_rratio 0.25))
+ (pad 2 smd roundrect (at 0.875 0) (size 1.05 0.95) (layers F.Cu F.Mask F.Paste) (roundrect_rratio 0.25))
(fp_text user %R (at 0 0) (layer F.Fab)
(effects (font (size 0.4 0.4) (thickness 0.06)))
)
|
The LED_handsolder definition is missing the pad size increase. will fix it shortly. |
This was discovered in KiCad#743 (comment)
@fauxpark I proposed a name change above to be more clear and extensible. Is that OK with you and can you rename these footprints? |
@evanshultz The handful of manufacturer STEP files from Digikey that I tested against seem to fit very well. |
@poeschlr - will you be adding this footprint to the script, or can it be merged? |
I will not script this. |
@fauxpark |
I have a handful of these lying around from a previous project and saw the existing reverse mount 1206 footprint was removed. This footprint isn't scripted but it is just a slightly modified 1206 footprint. Perhaps it is possible to make the script spit it out.
The NPTH may need to be elongated slightly to accomodate for more "square" lenses such as in this LED, or it could be a separate, Dialight-specific footprint.
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: