Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add 1206 reverse mount LED #743

Merged
merged 3 commits into from
Aug 6, 2018
Merged

Add 1206 reverse mount LED #743

merged 3 commits into from
Aug 6, 2018

Conversation

fauxpark
Copy link
Contributor

I have a handful of these lying around from a previous project and saw the existing reverse mount 1206 footprint was removed. This footprint isn't scripted but it is just a slightly modified 1206 footprint. Perhaps it is possible to make the script spit it out.

The NPTH may need to be elongated slightly to accomodate for more "square" lenses such as in this LED, or it could be a separate, Dialight-specific footprint.

fp
3d
fp2


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@evanshultz
Copy link
Collaborator

Whoa!?!?!? The footprint was added at #129, and removed with #469 (I assume accidentally when other chip-size footprints were updated). Is that what you were seeing?

@poeschlr @Shackmeister
Is that the right sequence of events and removing the reverse-mount LED footprint was an accident?

Do you want to add reverse mount LEDs to the script?

@fauxpark
You just added the 1.8mm hole to the existing footprint, right? 1.8mm is fine for the LED bulb/lens being round and 1.5-1.6mm. However, it won't accomodate the Kingbright LED and the footprint name isn't super clear. If this is to be a generic footprint for many vendors I think we should do something like LED_1206_3216Metric_ReverseMount_Hole1.8mm (round hole) or LED_1206_3216Metric_ReverseMount_Hole2.1x2.3mm (square hole). This will also allow a more accurate 3D model to fit the footprint.

@fauxpark
Copy link
Contributor Author

Yeah, I'm guessing it was removed because it now didn't match the scripted footprints. I don't see any other reverse mount LED packages apart from some oddball sizes that aren't scripted anyway.

I also pulled back the inner sides of the pads slightly to accommodate the hole. An oval hole would fit both the circular and square lenses, but I can make another footprint with a square hole if need be.

@poeschlr
Copy link
Collaborator

It was removed by accident.
I did not notice that there is a manually created footprint right in the middle of my scripted ones.

When i changed the pad size calculation i needed to delete the handsolder versions as they include the pad size in their name.
To make it easy for me i deleted everything between the smallest and largest standard chip resistor sizes and replaced it with the newly created ones. (I should have deleted only the handsolder versions. Sorry about that.)

@fauxpark
Copy link
Contributor Author

fauxpark commented Jul 13, 2018

Speaking of which, I just noticed the _HandSolder diodes and LEDs look exactly the same as the normal footprints. SMD caps and resistors are not. Is that intentional?

@poeschlr
Copy link
Collaborator

The Handsolder version has slightly longer pads. (The toe side is elongated.)

More detailed: right now the Zmax dimension (outside to outside between both pads) is increased by 0.35mm compared to the normal footprint. This means each pad is longer by 0.35/2 = 0.175mm.

Originally i determined this value by taking my own footprints that i regularly handsolder and looked how much larger their pads are when compared to the ipc suggestion. If somebody thinks this size increase is too small i can of course change that value. (I would not increase it by too much.)

@fauxpark
Copy link
Contributor Author

fauxpark commented Jul 15, 2018

The Handsolder version has slightly longer pads.

That's not what I'm seeing:

--- /Users/fauxpark/Git/kicad-footprints/Diode_SMD.pretty/D_0603_1608Metric.kicad_mod	Thu Jun 28 21:05:39 2018
+++ /Users/fauxpark/Git/kicad-footprints/Diode_SMD.pretty/D_0603_1608Metric_Pad0.88x0.95mm_HandSolder.kicad_mod	Thu Jun 28 21:05:39 2018
@@ -1,11 +1,11 @@
-(module D_0603_1608Metric (layer F.Cu) (tedit 5B301BBE)
+(module D_0603_1608Metric_Pad0.88x0.95mm_HandSolder (layer F.Cu) (tedit 5B301BBE)
   (descr "Diode SMD 0603 (1608 Metric), square (rectangular) end terminal, IPC_7351 nominal, (Body size source: http://www.tortai-tech.com/upload/download/2011102023233369053.pdf), generated with kicad-footprint-generator")
-  (tags diode)
+  (tags "diode handsolder")
   (attr smd)
   (fp_text reference REF** (at 0 -1.43) (layer F.SilkS)
     (effects (font (size 1 1) (thickness 0.15)))
   )
-  (fp_text value D_0603_1608Metric (at 0 1.43) (layer F.Fab)
+  (fp_text value D_0603_1608Metric_Pad0.88x0.95mm_HandSolder (at 0 1.43) (layer F.Fab)
     (effects (font (size 1 1) (thickness 0.15)))
   )
   (fp_line (start 0.8 -0.4) (end -0.5 -0.4) (layer F.Fab) (width 0.1))

Versus:

--- /Users/fauxpark/Git/kicad-footprints/Capacitor_SMD.pretty/C_0603_1608Metric.kicad_mod	Thu Jun 28 21:05:39 2018
+++ /Users/fauxpark/Git/kicad-footprints/Capacitor_SMD.pretty/C_0603_1608Metric_Pad1.05x0.95mm_HandSolder.kicad_mod	Thu Jun 28 21:05:39 2018
@@ -1,25 +1,25 @@
-(module C_0603_1608Metric (layer F.Cu) (tedit 5B301BBE)
-  (descr "Capacitor SMD 0603 (1608 Metric), square (rectangular) end terminal, IPC_7351 nominal, (Body size source: http://www.tortai-tech.com/upload/download/2011102023233369053.pdf), generated with kicad-footprint-generator")
-  (tags capacitor)
+(module C_0603_1608Metric_Pad1.05x0.95mm_HandSolder (layer F.Cu) (tedit 5B301BBE)
+  (descr "Capacitor SMD 0603 (1608 Metric), square (rectangular) end terminal, IPC_7351 nominal with elongated pad for handsoldering. (Body size source: http://www.tortai-tech.com/upload/download/2011102023233369053.pdf), generated with kicad-footprint-generator")
+  (tags "capacitor handsolder")
   (attr smd)
   (fp_text reference REF** (at 0 -1.43) (layer F.SilkS)
     (effects (font (size 1 1) (thickness 0.15)))
   )
-  (fp_text value C_0603_1608Metric (at 0 1.43) (layer F.Fab)
+  (fp_text value C_0603_1608Metric_Pad1.05x0.95mm_HandSolder (at 0 1.43) (layer F.Fab)
     (effects (font (size 1 1) (thickness 0.15)))
   )
   (fp_line (start -0.8 0.4) (end -0.8 -0.4) (layer F.Fab) (width 0.1))
   (fp_line (start -0.8 -0.4) (end 0.8 -0.4) (layer F.Fab) (width 0.1))
   (fp_line (start 0.8 -0.4) (end 0.8 0.4) (layer F.Fab) (width 0.1))
   (fp_line (start 0.8 0.4) (end -0.8 0.4) (layer F.Fab) (width 0.1))
-  (fp_line (start -0.162779 -0.51) (end 0.162779 -0.51) (layer F.SilkS) (width 0.12))
-  (fp_line (start -0.162779 0.51) (end 0.162779 0.51) (layer F.SilkS) (width 0.12))
-  (fp_line (start -1.48 0.73) (end -1.48 -0.73) (layer F.CrtYd) (width 0.05))
-  (fp_line (start -1.48 -0.73) (end 1.48 -0.73) (layer F.CrtYd) (width 0.05))
-  (fp_line (start 1.48 -0.73) (end 1.48 0.73) (layer F.CrtYd) (width 0.05))
-  (fp_line (start 1.48 0.73) (end -1.48 0.73) (layer F.CrtYd) (width 0.05))
-  (pad 1 smd roundrect (at -0.7875 0) (size 0.875 0.95) (layers F.Cu F.Mask F.Paste) (roundrect_rratio 0.25))
-  (pad 2 smd roundrect (at 0.7875 0) (size 0.875 0.95) (layers F.Cu F.Mask F.Paste) (roundrect_rratio 0.25))
+  (fp_line (start -0.171267 -0.51) (end 0.171267 -0.51) (layer F.SilkS) (width 0.12))
+  (fp_line (start -0.171267 0.51) (end 0.171267 0.51) (layer F.SilkS) (width 0.12))
+  (fp_line (start -1.65 0.73) (end -1.65 -0.73) (layer F.CrtYd) (width 0.05))
+  (fp_line (start -1.65 -0.73) (end 1.65 -0.73) (layer F.CrtYd) (width 0.05))
+  (fp_line (start 1.65 -0.73) (end 1.65 0.73) (layer F.CrtYd) (width 0.05))
+  (fp_line (start 1.65 0.73) (end -1.65 0.73) (layer F.CrtYd) (width 0.05))
+  (pad 1 smd roundrect (at -0.875 0) (size 1.05 0.95) (layers F.Cu F.Mask F.Paste) (roundrect_rratio 0.25))
+  (pad 2 smd roundrect (at 0.875 0) (size 1.05 0.95) (layers F.Cu F.Mask F.Paste) (roundrect_rratio 0.25))
   (fp_text user %R (at 0 0) (layer F.Fab)
     (effects (font (size 0.4 0.4) (thickness 0.06)))
   )

@poeschlr
Copy link
Collaborator

The LED_handsolder definition is missing the pad size increase. will fix it shortly.

poeschlr added a commit to poeschlr/kicad-footprints that referenced this pull request Jul 15, 2018
@evanshultz
Copy link
Collaborator

@fauxpark
Back to the reverse mount LEDs...

I proposed a name change above to be more clear and extensible. Is that OK with you and can you rename these footprints?

@fauxpark
Copy link
Contributor Author

@evanshultz
Done. I also decided to make the hole slightly wider to fit both lens shapes:

3d

The handful of manufacturer STEP files from Digikey that I tested against seem to fit very well.

@fauxpark
Copy link
Contributor Author

fauxpark commented Aug 1, 2018

@poeschlr - will you be adding this footprint to the script, or can it be merged?

@poeschlr
Copy link
Collaborator

poeschlr commented Aug 1, 2018

I will not script this.

@evanshultz
Copy link
Collaborator

@fauxpark
I think this should be fine. The inner pad clearance goes from 1.55mm to 2.15mm, but that's not a solderable surface on the LED. A ~0.5mm fillet can be formed on each end which should be OK. Thanks!

@evanshultz evanshultz merged commit e174bd6 into KiCad:master Aug 6, 2018
@fauxpark fauxpark deleted the led-1206-reverse branch August 6, 2018 23:13
@myfreescalewebpage myfreescalewebpage added the Addition Adds new footprint to library label Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants