Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix pad sizes for two terminal smd devices (issue #466) #469

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

poeschlr
Copy link
Collaborator

@poeschlr poeschlr commented Apr 5, 2018

The wrong IPC tables have been used for devices >=0603_1605Metric
For devices where the dimension S instead of T was given,
Smax was used instead fo Smax(RMS).

The example footprint given in #466:
Dimension G of the 2512 (6332Metric) footprint is now 4.54mm which is approximately Smin - 2Heel = 4.45 - 2(-0.05). The small difference comes from other considered tolerances.

Script pull request: pointhi/kicad-footprint-generator#119

The wrong IPC tables have been used for devices >=0603_1605Metric
For devices where the dimension S instead of T was given,
Smax was used instead fo Smax(RMS).
@poeschlr
Copy link
Collaborator Author

poeschlr commented Apr 9, 2018

@evanshultz @Ratfink @jkriege2 @Shackmeister

Can one of you take a look at this? The current smd two terminal footprints are not usable and this PR does fix that.

@Ratfink
Copy link
Collaborator

Ratfink commented Apr 9, 2018

Overall, this looks great to me! My one concern is that it looks like overly-conservative silkscreen-to-pad clearance caused 0805 parts to lose their silkscreen entirely, but the lines would be very short unless we go with the suggested clearance in #439, so this might be okay.

@Ratfink
Copy link
Collaborator

Ratfink commented Apr 9, 2018

Actually, @Shackmeister brought up a good point at KiCad/kicad-packages3D#280: some of the LED footprints we have (0201 and 01005) don't seem to have any real parts that fit them. I'd be in favor of removing those, as I mentioned in that thread.

@poeschlr
Copy link
Collaborator Author

poeschlr commented Apr 9, 2018

If i remember correctly then i checked it with either farnell or RS and i could find some parts that would fit them. I don't have time to check it again. And even if we decide to remove them this should be done in a separate PR anyways. (One topic per PR)

@poeschlr
Copy link
Collaborator Author

poeschlr commented Apr 13, 2018

Guys our current footprints are not usable for production. This PR (hopefully) fixes the problem. Could one of you guys look at it and decide if it can be merged?

Please only look at the size (edit: and position) of the pads. Other discussions should be made in a separate issue.

@Shackmeister
Copy link
Collaborator

pad sizes looks good to me, Ill merge it
But a few more eyes on this wouldnt hurt as it's some pretty important parts

a small script enhancement which could be added in the future, flip the Fab REF** is the package is wider than long

@Shackmeister Shackmeister merged commit 545a1dd into KiCad:master Apr 13, 2018
@evanshultz evanshultz mentioned this pull request Jul 12, 2018
4 tasks
@poeschlr poeschlr deleted the fix_padsize_rlc branch December 16, 2018 14:01
@myfreescalewebpage myfreescalewebpage added the Enhancement Improves existing footprint in the library label May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants