Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

R network split #325

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

evanshultz
Copy link
Collaborator

@evanshultz evanshultz commented Apr 23, 2020

Expand the script to make split (each resistor in its own unit) versions of all relevant resistor generators currently in the script.

Symbol PR: KiCad/kicad-symbols#2667

evanshultz added 2 commits April 22, 2020 21:59
- Add more relevant FP filters
- Re-factor the generator calls for clarity
- Also added 'SIP' to the name of one generator that is specifically for SIP packages
evanshultz and others added 2 commits April 23, 2020 09:38
- R_Network* now uses shorter pins on the bottom so the pin numbers are visible for both US and non-US symbols.
- All 'split' symbols are now generated with a single function using an extra argument to select the type of symbol
@evanshultz
Copy link
Collaborator Author

Symbols have been merged.

@vsergeev
Copy link

vsergeev commented May 14, 2020

👍 Found this after looking for R_Pack04_US. I noticed that the US style is currently only generated for the R_Network* variety. It would be awesome to pick up the US styles for the R_Pack* symbols too, if possible. I would contribute a diff here, but after taking a closer look, it looks like the body generation would have to be factored out and probably affect all of the generate functions, which is a bit beyond a simple patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants