-
Notifications
You must be signed in to change notification settings - Fork 742
Conversation
Note that R_Pack04_Split already existed, which oddly was the only one, and it changes just in having a RN ref des prefix like all other resistor networks and now has pin numbers visible
evanshultz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
You know, I will go ahead and do the R_Network*_US symbols just to get them done. But after sleeping. And then I'll upload the DCM file which I forgot. |
- Also modified the non-US symbols to use shorter bottom pins so the pin numbers don't crash into the symbol body.
It looks like I missed a period in my email address so CLA is barfing. While Gmail doesn't care about that apparently the CLA does. What is the way to proceed? Obviously it's safe to say I agree. |
Yes, that's probably safe to say. |
For reference, the one existing R_Pack_split was added here #2109 At the time I was not thinking of adding more scripted variants. Regarding the email-address, you can do a interactive rebase to do a |
@evanshultz no comment to do. |
R_Network*_Split units A and B showing the 'dummy' pin on units B and above:
R_Pack*_SIP_Split units A and B:
R_Pack*_Split:
The R_Network* symbols really should have 'SIP' in their name because they are only for pinouts in a SIP package. There are DIP and SOIC and convex/concave packages with bussed resistor networks, but they come in other pinouts. See https://www.bourns.com/docs/Product-Datasheets/4100R.pdf and http://www.vishay.com/docs/31511/31511.pdf and https://www.ctscorp.com/wp-content/uploads/766.pdf for DIP/SOIC, and then https://www.seielect.com/catalog/sei-ravf.pdf and https://industrial.panasonic.com/cdbs/www-data/pdf/AOC0000/AOC0000C12.pdf and https://www.ctscorp.com/wp-content/uploads/74x.pdf for concave/convex packages. This is just to show that while these symbol names don't include the word SIP, they have a SIP FP filter and we would need symbols with different pinouts to cover non-SIP packages.
Note that R_Pack04_Split already existed, which oddly was the only one, and it changes notably just in having a RN ref des prefix like all other resistor networks and now has pin numbers visible.
I didn't do the US resistor shapes but by the time I finished pasting these sections into the huge Device.lib file it probably would have been easier...
Script PR: KiCad/kicad-library-utils#325
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: