Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Move CH376 from Memory_Controller to to Interface #1144

Merged
merged 3 commits into from
Nov 19, 2018
Merged

Move CH376 from Memory_Controller to to Interface #1144

merged 3 commits into from
Nov 19, 2018

Conversation

antoniovazquezblanco
Copy link
Collaborator

See #18

@antoniovazquezblanco antoniovazquezblanco added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Nov 16, 2018
@evanshultz evanshultz self-assigned this Nov 16, 2018
@evanshultz
Copy link
Collaborator

Sorry about this, but since it's being touched I wanted to make sure this symbol was of appropriate quality. And no good deed goes unpunished. So would you mind making a few changes:

  • Do not duplicate the description as keywords.
  • Pin 16 should be Tri-state type.
  • Pin 4 should be Bidirectional type.
  • Pin 5 should be Input type.
  • Pin 7 should be Passive type.
  • Remove trailing tildes from pins 1 and 3.

@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Nov 19, 2018
@antoniovazquezblanco
Copy link
Collaborator Author

Thank you! Fixed!

@evanshultz
Copy link
Collaborator

And thank you!

@evanshultz evanshultz merged commit 22a80c0 into KiCad:master Nov 19, 2018
antoniovazquezblanco pushed a commit to antoniovazquezblanco/kicad-symbols that referenced this pull request Nov 21, 2018
antoniovazquezblanco added a commit to antoniovazquezblanco/kicad-symbols that referenced this pull request Nov 21, 2018
antoniovazquezblanco added a commit to antoniovazquezblanco/kicad-symbols that referenced this pull request Nov 26, 2018
* Move CH376 from Memory_Controller to to Interface

* Interface: Change pin name offset in CH376

* Interface: Fix CH376T pin types and description
evanshultz pushed a commit that referenced this pull request Mar 11, 2019
* Move CH376 from Memory_Controller to to Interface

* Interface: Change pin name offset in CH376

* Interface: Fix CH376T pin types and description
poeschlr added a commit that referenced this pull request Apr 14, 2019
poeschlr added a commit that referenced this pull request Apr 14, 2019
DaToBSn pushed a commit to DaToBSn/kicad-symbols that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-symbols: (228 commits)
  Added alias for MS5607 pressure sensor
  Fixed pin stacking
  Fix pin names
  Changes as requested
  Shrink pin length and number for small gnd crystals
  Save Device lib
  Update LT3010 with proper naming (KiCad#1458)
  Move CH376 from Memory_Controller to to Interface (KiCad#1144) (KiCad#1176)
  Add SSOP to fp-filter
  Add PIC18(L)F25/26K83 in DIP-28 (KiCad#1120)
  Address review comments for PocketBeagle
  - uploaded dcm for fixing description
  Fixed footprint filter
  - fixed footprint name in filter and description
  Added 2N7002K (KiCad#1615)
  Add PocketBeagle
  Implemented changes
  Implemented changes
  - added description to aliases
  - fixed naming - changed package from LQFP-64 to TQFP-64_10x10mm_P0.5mm - changed pin name offset to 20mil - changed pin length to 1000mil - removed stacking of positive power pin stacking - changed name of pin 21 from VDDIO to VDDIOB - fixed RESET pin name - moved reset pin to bottom left corner - VDDCORE -> Power Input - VSW -> Power Input (moved to the top of the symbol)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants