Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added 2N7002K #1615

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Added 2N7002K #1615

merged 1 commit into from
Mar 9, 2019

Conversation

jordiorlando
Copy link
Contributor

@jordiorlando jordiorlando commented Mar 8, 2019 •
edited
Loading

Added 2N7002K as an alias of BSS138
Datasheet: https://www.diodes.com/assets/Datasheets/ds30896.pdf

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@diegoherranz diegoherranz self-assigned this Mar 8, 2019
@diegoherranz diegoherranz added Addition Adds new symbols to library Ready for review Use this to mark pull requests that are updated but you could not review instantly labels Mar 8, 2019
@evanshultz evanshultz closed this Mar 8, 2019
@evanshultz evanshultz reopened this Mar 8, 2019
@evanshultz
Copy link
Collaborator

@diegoherranz
Are you going to take this? While 2N7002K (and other parts not sole-sourced) has varying parameters depending on which datasheet you read, this is probably fine so this PR looks good to me.

@myfreescalewebpage
Copy link
Collaborator

I would just say it's better with no extra space before values and units. I would ask to remove the spaces before "A" and "V" in the description. @0xdec

@evanshultz
Copy link
Collaborator

No space is my preference too, but because of the inconsistency everywhere with descriptions that go back before I started helping out here, and no guidelines in KLC, I just merge if I have no other comments during a review. But that's me. Maybe I'm wrong?

@myfreescalewebpage
Copy link
Collaborator

I'm not against merging @evanshultz, I know this is something to review and fix in all lib.

@diegoherranz
Copy link
Collaborator

Yes, I was planning on taking this.

The main comment I wanted to make was that this device does include gate protection diodes.
When I worked on #1237, I didn't include those with gate protection diodes since I thought that they would need a different symbol. Assuming that is the case, this would need a new symbol too. Although, obviously, it "works" with the symbol as is.

Any opinions on this?

Thanks!

@evanshultz
Copy link
Collaborator

IMO it's not worth it. This symbol still captures the device and the diodes don't add much. A note in the description wouldn't hurt, but I don't even think is necessary to merge.

Reviewing and polishing this library would be nice in the future, but I personally am in favor of merging as-is.

@jordiorlando
Copy link
Contributor Author

@myfreescalewebpage I also prefer no spaces in front of "A" and "V", but I just copied and modified the description from the existing 2N7002 devices. I'm happy to make any changes and rebase/force push if you think it's necessary.

@jordiorlando jordiorlando mentioned this pull request Mar 8, 2019
Merged
6 tasks
@jordiorlando
Copy link
Contributor Author

@myfreescalewebpage fixed the extraneous spaces issue, and also went through and fixed them for every other component in Transistor_FET in #1619

@diegoherranz
Copy link
Collaborator

IMO it's not worth it. This symbol still captures the device and the diodes don't add much. A note in the description wouldn't hurt, but I don't even think is necessary to merge.

OK. I'll merge.

Thanks, @0xdec, for your contribution.

@diegoherranz diegoherranz merged commit 5f41cdd into KiCad:master Mar 9, 2019
@diegoherranz diegoherranz removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Mar 9, 2019
@jordiorlando jordiorlando deleted the 2N7002K branch March 9, 2019 18:44
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.0 milestone Mar 11, 2019
DaToBSn pushed a commit to DaToBSn/kicad-symbols that referenced this pull request Jul 2, 2019
Merge branch 'master' of github.com:KiCad/kicad-symbols
1a8372d 
* 'master' of github.com:KiCad/kicad-symbols: (228 commits)
  Added alias for MS5607 pressure sensor
  Fixed pin stacking
  Fix pin names
  Changes as requested
  Shrink pin length and number for small gnd crystals
  Save Device lib
  Update LT3010 with proper naming (KiCad#1458)
  Move CH376 from Memory_Controller to to Interface (KiCad#1144) (KiCad#1176)
  Add SSOP to fp-filter
  Add PIC18(L)F25/26K83 in DIP-28 (KiCad#1120)
  Address review comments for PocketBeagle
  - uploaded dcm for fixing description
  Fixed footprint filter
  - fixed footprint name in filter and description
  Added 2N7002K (KiCad#1615)
  Add PocketBeagle
  Implemented changes
  Implemented changes
  - added description to aliases
  - fixed naming - changed package from LQFP-64 to TQFP-64_10x10mm_P0.5mm - changed pin name offset to 20mil - changed pin length to 1000mil - removed stacking of positive power pin stacking - changed name of pin 21 from VDDIO to VDDIOB - fixed RESET pin name - moved reset pin to bottom left corner - VDDCORE -> Power Input - VSW -> Power Input (moved to the top of the symbol)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@diegoherranz diegoherranz

Labels
Addition Adds new symbols to library
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jordiorlando @CLAassistant @evanshultz @myfreescalewebpage @diegoherranz @antoniovazquezblanco