-
Notifications
You must be signed in to change notification settings - Fork 742
Transistor_FET: Add Diodes Inc. N-Channel SOT-23 MOSFETs #1237
Conversation
Semi-scripted by filtering https://www.diodes.com/products/discrete/mosfets/mosfet-master-table/export/mosfet-master-table.xlsx and processing them with a quick and dirty script. See related PR (KiCad#1237). Only those without ESD gate protection, so that they can be aliases of BSS138. Note: the new CMPs were pasted at the bottom of the .dcm file and it was opened and saved within KiCad to reorder them. Some existant components were not in the right order and have been reordered too.
Semi-scripted by filtering https://www.diodes.com/products/discrete/mosfets/mosfet-master-table/export/mosfet-master-table.xlsx and processing them with a quick and dirty script. See related PR (KiCad#1237). Only those without ESD gate protection, so that they can be aliases of BSS138. Note: the new CMPs were pasted at the bottom of the .dcm file and it was opened and saved within KiCad to reorder them. Some existant components were not in the right order and have been reordered too.
Semi-scripted by filtering https://www.diodes.com/products/discrete/mosfets/mosfet-master-table/export/mosfet-master-table.xlsx and processing them with a quick and dirty script. See related PR (KiCad#1237). Only those without ESD gate protection, so that they can be aliases of BSS138. Note: the new CMPs were pasted at the bottom of the .dcm file and it was opened and saved within KiCad to reorder them. Some existant components were not in the right order and have been reordered too.
Hi @diegoherranz, thanks for this great contribution Just to summarize, following symbols added by this PR, with my comment when issue detected:
Symbols re-ordered in the lib:
Cheers, |
Thanks for the review.
The spreadsheet incorrectly says 5.5A! I'll fix them manually. And possibly report all this to Diodes Inc. for them to fix the spreadsheet. |
Yes of course! Checked each part added/moved in the git diff, opened each new part in kicad, open doc from kicad interface (to check link are not broken) and check datasheet for each of them. Finally checked moved parts in the lib have not been modified accidentally. Joel |
It's now not recommended for new designs and the link has changed.
The previous figures were taken from the master table spreadsheet provided by Diodes but the figures there are incorrect!
Thanks for the deep review. I wrongly assumed that the spreadsheet provided by Diodes Inc. would be correct! It should all be fixed. See the commits messages for more info. Regarding the following comment, I think that the datasheet link was correct already?
Thanks! |
:)
Checked your last commits, okay for me, no more comment. Probably I have not looked correctly the datasheet at this moment, verified again, it's okay for me too. Merging, thanks a lot for all these devices ! Joel |
Semi-scripted
By filtering https://www.diodes.com/products/discrete/mosfets/mosfet-master-table/export/mosfet-master-table.xlsx and processing it with a quick and dirty script. All of them added as aliases.
Selected:
After filtering the spreadsheet (
diodes_nfets_sot23.ods
), datasheet column replaced by a plain text URL (was a hyperlink) and saved as CSV.The CSV gets processed by
fet_aliases_gen.py
which prints the CMPs to be added to the.dcm
file and the list of part numbers to add to the.lib
.I pasted the aliases on the
.lib
and reordered manually (alphabetically).I pasted the CMPs at the end of the .dcm and opened and saved from within KiCad so that they get ordered properly.
Note: Some existant components were not in the right order and have been reordered too.
Datasheets and script used: fets_spreadsheets_script.zip
Thanks!
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: