Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

BQ25570: Nano power boost charger and buck converter #1728

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

ObKo
Copy link
Contributor

@ObKo ObKo commented Apr 10, 2019

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2019

CLA assistant check
All committers have signed the CLA.

@ObKo ObKo changed the title BQ25570: Nano power boost charger and buck converter for energy harve… BQ25570: Nano power boost charger and buck converter Apr 10, 2019
@jneiva08
Copy link
Contributor

hi,

The NC pins shoud be invisible and in the edge of square
The VSS should be stacked

@evanshultz evanshultz self-assigned this Apr 10, 2019
@myfreescalewebpage myfreescalewebpage added the Addition Adds new symbols to library label Apr 10, 2019
@evanshultz
Copy link
Collaborator

Welcome and thanks for contributing!

  1. Page 4 of the datasheet says the two NC pins should be connected to ground. So I'd support stacking them on the VSS pins.
  2. Let's use the datasheet description of Nano Power Boost Charger and Buck Converter for Energy Harvester Powered Applications.
  3. Then after that add on , QFN-20 to indicate the package.
  4. The footprint selected does not match the package for this part. We don't have any 3.5mm square QFN-20 footprints, but you can create it using the simple script at https://github.com/pointhi/kicad-footprint-generator/tree/master/scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON.
  5. VIN_DC should be on the top.
  6. If pin 4 is at the bottom of the left side the cap will have a clean path to ground. That pin can also change to Passive type.
  7. VOUT should be Input type.
  8. Change pins 16 and 20 to Passive type.
  9. Once all the pin movement is settled down see if you can shrink the symbol. It looks overly large above and stacking the pins should help even more.

@jneiva08
Thanks for taking a look.

@ObKo
Copy link
Contributor Author

ObKo commented Apr 11, 2019

VOUT should be Input type.

Power input or Input? And why, it's output of buck converter providing power, or do I misunderstand Power output pin type?

Once all the pin movement is settled down see if you can shrink the symbol. It looks overly large above and stacking the pins should help even more.

The main problem are resistor divider inputs on the right side (pin 7, 10-12) - all dividers must be driven by pin 8 (see example schematic). So, they should be together and near pin 8. The best I can do:

bq25570_n

The footprint selected does not match the package for this part.

Oh, that was surprisingly. It indeed narrower that common QFN-20, I will open new pull request for footprint.

@ObKo
Copy link
Contributor Author

ObKo commented Apr 11, 2019

@ObKo
Copy link
Contributor Author

ObKo commented Apr 11, 2019

bq25570_2
IMO better keep VIN_DC on the left side, on same level as VOUT for clear VIN->VOUT path.

@evanshultz
Copy link
Collaborator

  1. The wire going to VSTOR does make it look ugly, but that connection depends on the application. Our library requirements are power pin at the top and I'd like to stick with that.
  2. The purpose of VOUT, as shown in the block diagram on page 14 of the datasheet, is to provide input to the PWM controller. So it's an input. This one is unusual because the VOUT_SET pin means this isn't a dedicated feedback pin that has a resistor (or other network) from the voltage output. The same net will need a PWR_FLAG symbol to indicate it can source power. Unless another librarian has another suggestion.
  3. Looking at the original symbol, my main suggestion was to shrink vertically once VSS is stacked and the NC pins are gone.

@ObKo
Copy link
Contributor Author

ObKo commented Apr 12, 2019

BQ25570

@evanshultz
Copy link
Collaborator

Thanks! Just a couple things left in addition to the footprint:

  1. Remove the space at the front of the keywords
  2. Change the footprint filter to QFN*1EP*3.5x3.5mm*P0.5mm*.

@evanshultz
Copy link
Collaborator

Looks good now. Thanks!

@evanshultz evanshultz merged commit c2169f6 into KiCad:master Apr 23, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Apr 24, 2019
DaToBSn pushed a commit to DaToBSn/kicad-symbols that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-symbols: (181 commits)
  Fix OKI*78SR* footprint filters
  Swap pins of BPW21
  Driver_LED/DIO5661x: Update datasheet link
  BQ25570: Nano power boost charger and buck converter (KiCad#1728)
  Driver_LED/DIO5661x: Update footprint info, description, datasheet
  Disambiguate 74xx04 and 74xx14 to have the hysteresis symbol on the latter.
  Driver_LED/DIO5661CD6: Correct stacked GND
  Driver_LED: Split DIO5661x into atomic components
  Add shield pin to Wuerth_7499010121A (KiCad#1500)
  changes made following review by Joel
  Driver_LED: Update DIO5661 footprint filter
  Driver_LED: Add DIO5661x
  added metadata keywords and footprint filter
  74LVC1G14, 74LVC2G14, 74LVC3G14: Fix datasheet links.
  Fix hysteresis symbol in 74xG14 which was mirrored.
  Add missing hysteresis symbol on 74LS14 (and 74HC14 alias)
  remove duplicated keyword
  add "Connector for" to description. Datasheet is only URL. Document-names to keywords.
  fixed: pinstacking of power pins. length of pins. tilde as bar on top
  changes as suggester by review. add datasheet document name and link.
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants