-
Notifications
You must be signed in to change notification settings - Fork 175
Conversation
Code Climate has analyzed commit d35da11 and detected 0 issues on this pull request. View more on Code Climate. |
#ipc_density: 'least' #overwrite global value for this device. | ||
# custom_name_format: | ||
body_size_x: | ||
nominal: 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the dimensions as in the datasheet. Here, input min and max (3.35mm and 3.65mm) instead of nominal and tolerance.
tolerance: 0 | ||
overall_height: | ||
minimum: 0.8 | ||
nominal: 0.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No nominal is given. Please remove it.
|
||
lead_width: | ||
minimum: 0.18 | ||
nominal: 0.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove nominal.
maximum: 0.3 | ||
lead_len: | ||
minimum: 0.3 | ||
nominal: 0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove nominal.
|
||
EP_size_x: | ||
minimum: 1.9 | ||
nominal: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nominal is given for both X and Y dimensions of the EP.
Comments made inline to the changed file. If you look at the diff on GH it appears messed up, but I assume that's because the last section of this footprint matches the corresponding section for the footprint above. When GH sees it it doesn't realize the best way to display the diff. Correct? |
Also known as TI's S-PVQFN-N20.
Fixed issues. |
Thanks! This looks good now. Did you regenerate the footprint and check to see if anything changed? In the future, it's easier to review if you don't force push commits. |
Yes, I'd regenerated footprint and checked it. |
@pointhi |
Also known as TI's S-PVQFN-N20
http://www.ti.com/lit/ml/mpqf239/mpqf239.pdf