Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Add 3.5x3.5mm QFN-20 with 2mm pad. #339

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Add 3.5x3.5mm QFN-20 with 2mm pad. #339

merged 1 commit into from
Apr 23, 2019

Conversation

ObKo
Copy link
Contributor

@ObKo ObKo commented Apr 11, 2019

Also known as TI's S-PVQFN-N20

http://www.ti.com/lit/ml/mpqf239/mpqf239.pdf

qfn-20-doc

qfn-20

@codeclimate
Copy link

codeclimate bot commented Apr 11, 2019

Code Climate has analyzed commit d35da11 and detected 0 issues on this pull request.

View more on Code Climate.

#ipc_density: 'least' #overwrite global value for this device.
# custom_name_format:
body_size_x:
nominal: 3.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the dimensions as in the datasheet. Here, input min and max (3.35mm and 3.65mm) instead of nominal and tolerance.

tolerance: 0
overall_height:
minimum: 0.8
nominal: 0.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No nominal is given. Please remove it.


lead_width:
minimum: 0.18
nominal: 0.25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove nominal.

maximum: 0.3
lead_len:
minimum: 0.3
nominal: 0.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove nominal.


EP_size_x:
minimum: 1.9
nominal: 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nominal is given for both X and Y dimensions of the EP.

@evanshultz
Copy link
Collaborator

Comments made inline to the changed file.

If you look at the diff on GH it appears messed up, but I assume that's because the last section of this footprint matches the corresponding section for the footprint above. When GH sees it it doesn't realize the best way to display the diff. Correct?

Also known as TI's S-PVQFN-N20.
@ObKo
Copy link
Contributor Author

ObKo commented Apr 12, 2019

Fixed issues.

@evanshultz
Copy link
Collaborator

Thanks! This looks good now.

Did you regenerate the footprint and check to see if anything changed?

In the future, it's easier to review if you don't force push commits.

@ObKo
Copy link
Contributor Author

ObKo commented Apr 23, 2019

Yes, I'd regenerated footprint and checked it.

@evanshultz
Copy link
Collaborator

@pointhi
The footprint has been merged.

@pointhi pointhi merged commit 54c675a into pointhi:master Apr 23, 2019
@ObKo ObKo deleted the qfn-3.5 branch April 26, 2019 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants