Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Cleaned up micro controller lib symbols #83

Merged
merged 10 commits into from
Dec 22, 2017
Merged

Cleaned up micro controller lib symbols #83

merged 10 commits into from
Dec 22, 2017

Conversation

DerekGn
Copy link
Contributor

@DerekGn DerekGn commented Dec 20, 2017

Cleaned up symbols in following libraries

  • MCU_Microchip_PIC10.lib
  • MCU_Microchip_PIC12.lib
  • MCU_NXP_S08.lib

from issue #25

PIC libary example:

image


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@DerekGn DerekGn changed the title Cleaned up MCU_Microchip_PIC10.lib symbols Cleaned up micro controller lib symbols Dec 21, 2017
@DerekGn DerekGn closed this Dec 21, 2017
@DerekGn DerekGn reopened this Dec 21, 2017
@SchrodingersGat
Copy link
Contributor

These look good, thanks for the upgrades :)

@SchrodingersGat SchrodingersGat merged commit a11b1d4 into KiCad:master Dec 22, 2017
@DerekGn
Copy link
Contributor Author

DerekGn commented Dec 23, 2017

I will work through the rest of the libs from #25 over the next few days/weeks. Some of the libs need quite a bit of work.

@jkriege2
Copy link
Collaborator

jkriege2 commented Dec 23, 2017

Hi!

please also revisit this PR minding what I posted there: #96 (comment) ... the footprint fields should really be set, when there is only one footprint!

Also the device name should not reappear in the description field, e.g. you added PIC10F200 it to PIC10F200, 256W Flash, 16B SRAM, PDIP8. A better description would maybe be PIC10-family microcontroller, 256W Flash, 16B SRAM, PDIP-8, see http://kicad-pcb.org/libraries/klc/S6.3/ for details!

@DerekGn DerekGn deleted the mcu_issues branch December 23, 2017 19:21
@myfreescalewebpage myfreescalewebpage added the Enhancement Improves existing symbol in the library label May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants