Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Cleaned up issues for MCU_NXP_LPC.lib #96

Merged
merged 3 commits into from
Dec 24, 2017
Merged

Cleaned up issues for MCU_NXP_LPC.lib #96

merged 3 commits into from
Dec 24, 2017

Conversation

DerekGn
Copy link
Contributor

@DerekGn DerekGn commented Dec 23, 2017

Cleaned up build issues for MCU_NXP_LPC.lib from #25

image

@DerekGn DerekGn changed the title Resolved jenkins issues for MCU_NXP_LPC.lib Cleaned up issues for MCU_NXP_LPC.lib Dec 23, 2017
@jkriege2
Copy link
Collaborator

Hi!

THanks for the contribution. I had a quick look at it ... is there a reason why you removed the footpritn fields? Are these devices meant for different footprints each? If there is only one footprint per device, set the footprint field (see http://kicad-pcb.org/libraries/klc/S5.1/ and http://kicad-pcb.org/libraries/klc/S5.2/) to point to that footprint AND the footprint filter (FPFilter) to match that footprint (+possible variants, like _HandSoldering ...). An example:
LPC1102UK pointed to Package_CSP:WLCSP-16_4x4_2.17x2.32mm_P0.5mm, which was renamed to Package_CSP:WLCSP-16_4x4_B2.17x2.32mm_P0.5mm, so the footprint field should be set for the second (newer) version.
The FPFilter then does not have to contain the package lib. In the case above it should be simply WLCSP*4x4*B2.17x2.32mm*P0.5mm*.

Could you modify your PR accordingly?

Thanks,
JAN

@DerekGn
Copy link
Contributor Author

DerekGn commented Dec 23, 2017

Ok I missed the fact that the FP should be set with the FP filter. I will fix and update PR.

@jkriege2
Copy link
Collaborator

Hi!

nice work, thanks!
One last thing: Could you remove the pin-count 16 from the WLSCP-package FPFilter?

Thanks,
JAN

PS: Could you also take a second look at your older work there: #83

@DerekGn
Copy link
Contributor Author

DerekGn commented Dec 23, 2017

I am working on #83 at the moment
Part 1 here #97
Part 2 here #98

you mean change this WLCSP*16*4x4*B2.17x2.32mm*P0.5mm* to this WLCSP*4x4*B2.17x2.32mm*P0.5mm*?

For reference why is the pin number a problem?

@jkriege2
Copy link
Collaborator

yes, that's what I meant.

Pin count is not a "problem" ... we distinguish two cases here:

  1. Symbols that have all pins (also NC pins) have the same number of pins in the symbol as are found in the package. Therefore KiCADs own pin-count filter is used to match out the correct footprint (e.g. for DIP*W7.62mm* will match all naroow DIPs, but the pin-count filter will narrow it down to say a DIP-8). Tehrefore pin-count is not necessary
  2. In contrast there may be symbols where you don't place all pins (e.g. a reference diode in DIP-8, as you really cannot place all those 6 NC pins ...). Then we need the pin-count in the filter as the pin-count filter in KiCAD does not work for such cases!

@jkriege2
Copy link
Collaborator

PS: The KLC is not that specific about this, it just states to include all "dimensional information" ...
PPS: Bear in mind: This is one of the less important rules in KLC ;-)

@DerekGn
Copy link
Contributor Author

DerekGn commented Dec 24, 2017

Right that all makes sense I had forgotten about KiCADs own pin-count filter. So there is no need set the pin count explicitly in the Fpfilter. I will fix.

@jkriege2
Copy link
Collaborator

Thanks,
JAN

@jkriege2 jkriege2 merged commit 4646ac3 into KiCad:master Dec 24, 2017
@DerekGn DerekGn deleted the MCU_NXP_LPC.lib branch December 27, 2017 13:39
@myfreescalewebpage myfreescalewebpage added the Enhancement Improves existing symbol in the library label May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants