Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the xacro based on the test on real j2n6s300 robot #443

Closed

Conversation

yuzhongchun17
Copy link

Fixed the joint limit for joint 5 based on the real robot properties (with 1 deg torlerance).

@martinleroux
Copy link

Hi @yuzhongchun17 ,
Thanks a lot for your contribution!
We are currently preparing for IROS and our focus is mostly on our ros2_kortex repo, so we are a bit short-handed to look at this PR in the short term, but rest assured that we will have a look at it as soon as we have time.

@martinleroux
Copy link

I see you are still making changes that are not based on our review and also notice modifications that seem to only belong in your own personal project, not in our repo, so I will be closing this PR. If you really intended to contribute, don't hesitate to open a new one once you have finalized your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants