Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on gz-ros2-control instead of gazebo-ros2-control #159

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abake48
Copy link
Contributor

@abake48 abake48 commented Jul 27, 2023

We currently don't support Gazebo classic and have focused on support Ignition Gazebo so we should no longer depend on gazebo_ros2_control and instead depend on gz_ros2_control.

This will benefit the user because gazebo-ros2-control and gz-ros2-control currently conflict with each other.

@abake48 abake48 requested a review from moriarty July 27, 2023 17:42
@moriarty
Copy link
Collaborator

moriarty commented Jul 31, 2023

Rolling Binary Build
Rolling + Main failed:

  ERROR: the following rosdeps failed to install
    apt: command [apt-get install -y -qq ros-rolling-gz-ros2-control] failed
  '( source /home/runner/work/ros2_kortex/ros2_kortex/.work/upstream_ws/install/setup.bash && rosdep install -q --from-paths /home/runner/work/ros2_kortex/ros2_kortex/.work/target_ws/src --ignore-src -y | grep -E '(executing command)|(Setting up)' ; )' returned with 1
'install_target_dependencies' returned with code '1' after 0 min 37 sec

I think this is in a weird state right now due to the recent changes upstream
ros/rosdistro#37773

It looks like gz-ros2-control is available on main with Iron but not yet for Rolling. It is available on testing for rolling but our github jobs are setup to fail fast and not run the other matrix option.

image

image

This just means we need to wait until the next package sync for Rolling before merging.

Copy link
Collaborator

@moriarty moriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to wait for the next ros-sync before we merge this because the package rename hasn't been synced yet.

@abake48 abake48 marked this pull request as draft August 2, 2023 18:17
@henningkayser
Copy link

@abake48, @moriarty, @smoya23 any chance this could be moved forward? gazebo-ros2-control has been phased out, so Rolling and Jazzy builds are failing because of the missing dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants