Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug of internal error being thrown after a redeclaration of a variable #463

Conversation

Luna-Klatzer
Copy link
Member

What type of change does this PR perform?

  • Bug fix (Non-breaking change which fixes an issue)

Summary

Fixed bug of internal error being thrown after a redeclaration of a variable.

Closes #462

Summary of Changes

Does this PR create new warnings?

No.

Detailed Changelog

Not present for website/docs changes

Added

  • New function ensureScopeDeclarationAvailableIfNeeded, which ensures that a scope declaration is available if needed. This is used during the semantic analysis/type checking of a declaration statement, which may need the scope declaration object during the processing.

Fixed

  • Redeclaration bug causing an InternalError after calling the compiler (#462).

Linked issues or PRs

@Luna-Klatzer Luna-Klatzer added bug Bug or issue in the language or API fix Fixes an issue or bug labels Jun 7, 2023
@Luna-Klatzer Luna-Klatzer self-assigned this Jun 7, 2023
@Luna-Klatzer Luna-Klatzer changed the base branch from main to dev June 7, 2023 12:42
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.08 ⚠️

Comparison is base (fa8d30e) 84.29% compared to head (2c3f40b) 84.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #463      +/-   ##
==========================================
- Coverage   84.29%   84.22%   -0.08%     
==========================================
  Files          61       61              
  Lines        2025     2028       +3     
  Branches      248      249       +1     
==========================================
+ Hits         1707     1708       +1     
- Misses        202      203       +1     
- Partials      116      117       +1     
Impacted Files Coverage Δ
kipper/core/src/compiler/ast/nodes/definitions.ts 84.54% <50.00%> (-1.44%) ⬇️
...ipper/core/src/compiler/ast/analysable-ast-node.ts 85.48% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./kipper/web/kipper-standalone.min.js 128.4 KB (0%) 2.6 s (0%) 1.1 s (-7.85% 🔽) 3.7 s
./kipper/web/kipper-standalone.js 128.45 KB (0%) 2.6 s (0%) 1.3 s (+2.04% 🔺) 3.9 s

@Luna-Klatzer Luna-Klatzer merged commit c3fb5c8 into dev Jun 7, 2023
@Luna-Klatzer Luna-Klatzer deleted the 462-bug-internal-error-after-redeclaration-of-variable-0.10.0 branch June 7, 2023 13:14
@Luna-Klatzer Luna-Klatzer added this to the v0.10.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or issue in the language or API fix Fixes an issue or bug
Projects
Development

Successfully merging this pull request may close these issues.

[Bug] Internal error after redeclaration of variable
1 participant