Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10.2 #471

Closed
wants to merge 29 commits into from
Closed

v0.10.2 #471

wants to merge 29 commits into from

Conversation

Luna-Klatzer
Copy link
Member

@Luna-Klatzer Luna-Klatzer commented Jun 16, 2023

What type of change does this PR perform?

  • Bug fix (Non-breaking change which fixes an issue)

Summary

New minor bug-fix version 0.10.2, which fixes multiple bugs in the previous version.

Summary of Changes

Does this PR create new warnings?

None.

Detailed Changelog

Not present for website/docs changes

Added

  • New field:
    • KipperError.programCtx, which contains, if KipperError.tracebackData.errorNode is not undefined, the program context of the error.
  • New function:
    • ensureScopeDeclarationAvailableIfNeeded, which ensures that a scope declaration is available if needed. This is used during the semantic analysis/type checking of a declaration statement, which may need the scope declaration object during the processing.

Fixed

  • Redeclaration bug causing an InternalError after calling the compiler (#462).
  • Compiler argument bug in KipperCompiler, where abortOnFirstError didn't precede recover, meaning that instead of an error being thrown the failed result was returned (As defined in the recover behaviour, which is incorrect).
  • Bug of invalid underline indent in error traceback. (#434).

Linked issues or PRs

…ntlr4 parser

This is due to the fact generating the parser should be preferably done on the root level, as the lexer and parser are usually also referenced in other packages
This is due to unexpected conflicts when performing tests, as that ts-node version is seemingly incompatible with typescript 4.9.x
The bug caused `abortOnFirstError` to not precede `recover`, meaning that instead of an error being thrown the failed result was returned
Signed-off-by: Luna <luna.klatzer@gmail.com>
(cherry picked from commit b51f3d7)
…r-redeclaration-of-variable-0.10.0

Fixed bug of internal error being thrown after a redeclaration of a variable
Fixed typo in the URL in line 34

Signed-off-by: Luna <luna.klatzer@gmail.com>
The bug was caused due to an invalid usage of `tokenSrc`, where actually using `srcLine` makes more sense.
…nderline-in-error-traceback-0.10.0

Fixed bug of invalid underline indent in error traceback
@Luna-Klatzer Luna-Klatzer added release New release of the Kipper module. skip changelog Do not include in the changelog when a new release is drafted labels Jun 16, 2023
@Luna-Klatzer Luna-Klatzer added this to the v0.10.0 milestone Jun 16, 2023
@Luna-Klatzer Luna-Klatzer self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.16 ⚠️

Comparison is base (58478ec) 84.37% compared to head (25dc350) 84.22%.

❗ Current head 25dc350 differs from pull request most recent head fbdf360. Consider uploading reports for the commit fbdf360 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   84.37%   84.22%   -0.16%     
==========================================
  Files          61       61              
  Lines        2023     2028       +5     
  Branches      247      249       +2     
==========================================
+ Hits         1707     1708       +1     
- Misses        201      203       +2     
- Partials      115      117       +2     
Impacted Files Coverage Δ
kipper/core/src/compiler/ast/nodes/definitions.ts 84.54% <50.00%> (-1.44%) ⬇️
kipper/core/src/compiler/compiler.ts 91.42% <66.66%> (-2.69%) ⬇️
...ipper/core/src/compiler/ast/analysable-ast-node.ts 85.48% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@oclif/command 🆕 1.8.26 environment +1 58.9 kB salesforce-releases

Footnotes

  1. https://docs.socket.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./kipper/web/kipper-standalone.min.js 128.42 KB (0%) 2.6 s (0%) 1.3 s (+6.28% 🔺) 3.8 s
./kipper/web/kipper-standalone.js 128.48 KB (0%) 2.6 s (0%) 1.2 s (+11.38% 🔺) 3.8 s

This is due to an unexpected issue of the newer versions having a version conflict and the @kipper/cli package not having moved to v2 of oclif yet.
@Luna-Klatzer Luna-Klatzer deleted the dev branch June 16, 2023 18:23
@Luna-Klatzer Luna-Klatzer restored the dev branch June 16, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release New release of the Kipper module. skip changelog Do not include in the changelog when a new release is drafted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant