Standardised error output of the @kipper/cli
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luna <luna.klatzer@gmail.com>
Signed-off-by: Luna <luna.klatzer@gmail.com>
Signed-off-by: Luna <luna.klatzer@gmail.com>
Signed-off-by: Luna <luna.klatzer@gmail.com>
Signed-off-by: Luna <luna.klatzer@gmail.com>
Minor README.md content update
…e-kippercli Signed-off-by: Luna <luna.klatzer@gmail.com>
size-limit report 📦
|
…ut-of-the-kippercli' into 435-other-standardise-error-output-of-the-kippercli
The logger already handles the error, so the error must be caught and then ignored.
…ut-of-the-kippercli' into 435-other-standardise-error-output-of-the-kippercli
Luna-Klatzer
deleted the
435-other-standardise-error-output-of-the-kippercli
branch
This was referenced Jul 22, 2023
Merged
Luna-Klatzer
added a commit
that referenced
this pull request
Jul 22, 2023
* Fixed bug according to #451 * Updated CHANGELOG.md * Prettified code * Standardised error output of the `@kipper/cli` (#489) * Update README.md Signed-off-by: Luna <luna.klatzer@gmail.com> * Updated and simplified PULL_REQUEST_TEMPLATE.md Signed-off-by: Luna <luna.klatzer@gmail.com> * Update PULL_REQUEST_TEMPLATE.md Signed-off-by: Luna <luna.klatzer@gmail.com> * Update README.md Signed-off-by: Luna <luna.klatzer@gmail.com> * Added missing space in `kipper` README.md Signed-off-by: Luna <luna.klatzer@gmail.com> * Restructured CLI and implemented standardised prettified errors * Removed suffix message from `KipperInternalError` * Updated CHANGELOG.md * Fixed accidentally renamed args property in `getFile` * Fixed invalid use of `getTarget` in analyse.ts * Renamed `getFile` to `getParseStream` * Updated CHANGELOG.md * Fixed `LogLevel` being too high in analyse.ts * Fixed error being thrown in analyse.ts The logger already handles the error, so the error must be caught and then ignored. * Prettified code * Updated analyse.test.ts to fit code changes * Updated analyse.test.ts to fit code changes * Updated CHANGELOG.md --------- Signed-off-by: Luna <luna.klatzer@gmail.com> --------- Signed-off-by: Luna <luna.klatzer@gmail.com>
This was referenced Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change does this PR perform?
Summary
Standardized
@kipper/clioutput and cleaned up the code base.Closes #435
List of Changes
Does this PR create new warnings?
No.
Detailed Changelog
Added
@kipper/cli:input, which contains all input-related handling functions and classes.output, which contains the output-related handling functions and classes.prettifiedErrorsin@kipper/cli, which applies standardised error formatting to any thrown error.Changed
KipperInternalError, which does not have " - Report this bug to the developer using the traceback!" as a suffix anymore.getFiletogetParseStream.Linked issues or PRs