Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync bug fixes for issues #435, #451 & #491 to v0.11 #510

Merged
merged 103 commits into from
Oct 21, 2023

Conversation

Luna-Klatzer
Copy link
Member

@Luna-Klatzer Luna-Klatzer commented Oct 21, 2023

What type of change does this PR perform?

  • Maintenance (Non-breaking change that updates dependencies)
  • Info or documentation change (Non-breaking change that updates repo info files (e.g. README.md, CONTRIBUTING.md, etc.) or online documentation)
  • Website feature update or docs development changes (Change that changes the design or functionality of the websites or docs)
  • Development or internal changes (These changes do not add new features or fix bugs, but update the code in other ways)
  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Major bug fix or feature that would cause existing functionality not to work as expected.)
  • Requires a documentation update, as it changes language or compiler behaviour

Summary

Syncs the following bug fixes and adds them to the dev branch:

List of Changes

Does this PR create new warnings?

No.

Detailed Changelog

Changed

  • Standardised error output for the CLI as described in #435. (This is the same change as in 0.10.3, but was only added to the dev branch with the release of 0.11.0-alpha.1 i.e. 0.11.0-alpha.0 does not have this change).

Fixed

  • CLI bug where the -t shortcut flag was incorrectly shown for the command help compile. (#451) (This is the same fix as in 0.10.3, but was only added to the dev branch with the release of 0.11.0-alpha.1 i.e. 0.11.0-alpha.0 still has this bug).
  • CLI error handling bug as described in #491. This includes multiple bugs where errors were reported as "Unexpected CLI Error". (This is the same fix as in 0.10.4, but with one additional edge-case covered. This fix was only added to the dev branch with the release of 0.11.0-alpha.1 i.e. 0.11.0-alpha.0 still has this bug).

Linked issues or PRs

Luna-Klatzer and others added 30 commits May 8, 2023 18:17
Signed-off-by: Luna <luna.klatzer@gmail.com>
(cherry picked from commit b51f3d7)
…r-redeclaration-of-variable-0.10.0

Fixed bug of internal error being thrown after a redeclaration of a variable
Fixed typo in the URL in line 34

Signed-off-by: Luna <luna.klatzer@gmail.com>
The bug was caused due to an invalid usage of `tokenSrc`, where actually using `srcLine` makes more sense.
…nderline-in-error-traceback-0.10.0

Fixed bug of invalid underline indent in error traceback
This is due to an unexpected issue of the newer versions having a version conflict and the @kipper/cli package not having moved to v2 of oclif yet.
…possible-alias-for-log-timestamp-flag-in-compile-cli-commmand

Fixed bug where the `-t` flag was shown as possible alias for the flag `--log-timestamp` in the `compile` command
@Luna-Klatzer Luna-Klatzer added bug Bug or issue in the language or API fix Fixes an issue or bug labels Oct 21, 2023
@Luna-Klatzer Luna-Klatzer added this to the v0.11.0 milestone Oct 21, 2023
@Luna-Klatzer Luna-Klatzer self-assigned this Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Files Coverage Δ
kipper/cli/src/commands/analyse.ts 100.00% <100.00%> (+8.69%) ⬆️
kipper/cli/src/commands/help.ts 83.33% <100.00%> (ø)
kipper/cli/src/commands/version.ts 75.00% <100.00%> (ø)
kipper/cli/src/errors.ts 54.54% <ø> (ø)
kipper/cli/src/input/index.ts 100.00% <100.00%> (ø)
kipper/cli/src/logger.ts 66.66% <ø> (ø)
kipper/cli/src/output/compile.ts 95.00% <100.00%> (ø)
kipper/cli/src/output/index.ts 100.00% <100.00%> (ø)
kipper/core/src/compiler/index.ts 100.00% <100.00%> (ø)
...ore/src/compiler/parser/parse-rule-kind-mapping.ts 100.00% <ø> (ø)
... and 9 more

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./kipper/web/kipper-standalone.min.js 135.78 KB (0%) 2.8 s (0%) 176 ms (+63.08% 🔺) 2.9 s
./kipper/web/kipper-standalone.js 135.83 KB (0%) 2.8 s (0%) 185 ms (+24.84% 🔺) 3 s

@Luna-Klatzer Luna-Klatzer force-pushed the 435-451-491-bug-fixes-sync-to-v0-11 branch from 67fd5d5 to c269b73 Compare October 21, 2023 13:23
@Luna-Klatzer Luna-Klatzer force-pushed the 435-451-491-bug-fixes-sync-to-v0-11 branch from c269b73 to 096f221 Compare October 21, 2023 13:25
@Luna-Klatzer Luna-Klatzer merged commit 1fc86d4 into dev-next Oct 21, 2023
15 of 18 checks passed
@Luna-Klatzer Luna-Klatzer deleted the 435-451-491-bug-fixes-sync-to-v0-11 branch October 21, 2023 13:32
@Luna-Klatzer Luna-Klatzer mentioned this pull request Feb 10, 2024
16 tasks
@Luna-Klatzer Luna-Klatzer mentioned this pull request Jul 10, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or issue in the language or API fix Fixes an issue or bug
Projects
1 participant