-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug of regular errors being reported as unexpected cli error despite expected failure #502
Merged
Luna-Klatzer
merged 7 commits into
dev-main
from
491-bug-regular-errors-are-reported-as-unexpected-cli-error-despite-expected-failure
Aug 15, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes `KipperCompileResult.warnings` always be an array even if `compileCtx` is undefined. This is to preserve cohesion with the previous bug-fix release `v0.10.3`
Luna-Klatzer
added
bug
Bug or issue in the language or API
fix
Fixes an issue or bug
labels
Aug 15, 2023
size-limit report 📦
|
Luna-Klatzer
deleted the
491-bug-regular-errors-are-reported-as-unexpected-cli-error-despite-expected-failure
branch
August 15, 2023 12:36
This was referenced Aug 15, 2023
Merged
Luna-Klatzer
restored the
491-bug-regular-errors-are-reported-as-unexpected-cli-error-despite-expected-failure
branch
October 21, 2023 10:34
3 tasks
14 tasks
Luna-Klatzer
deleted the
491-bug-regular-errors-are-reported-as-unexpected-cli-error-despite-expected-failure
branch
October 21, 2023 11:51
14 tasks
This was referenced Jun 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change does this PR perform?
Summary
Fixed bugs in the
@kipper/cli
and@kipper/core
packages, where some error-handling edge cases weren't covered and caused issues.Closes #491
List of Changes
KipperCompiler.compile()
. This means that syntax errors will not be thrown anymore unless the argumentabortOnFirstError
is specified, but also that syntax errors will be returned through aKipperCompileResult
instance that stores them in theerrors
property. (Same behaviour as with semantic or type errors) This also means thatKipperCompileResult.programCtx
can now beundefined
, if there has been a syntax error, as at that stage of compilation it can not be created.--abort-on-first-error
. This does not include the compile argumentCompileConfig.abortOnFirstError
.Does this PR create new warnings?
No.
Detailed Changelog
Changed
executeKipperProgram
toRun
as a private function.KipperCompileResult
to new filecompile-result.ts
in the same directory.KipperCompileResult.programCtx
can now be alsoundefined
, due to the changed behaviour that nowa
KipperCompileResult
is also returned for syntax errors (where it has no value).Fixed
multiple bugs where errors were reported as "Unexpected CLI Error".
Deprecated
--abort-on-first-error
in favour of--no-recover
. #501.Linked issues or PRs