async cells are sometimes executed out of order

[saraedum]

Running all cells in this notebook (with Cell → Run All) executes cells out of order:

This happened with the latest version of this package and the latest notebook from conda-forge.

I am happy to provide more details if that is helpful.

[saraedum]

This is likely because I am on ipykernel 5.5.5.

[saraedum]

I don't claim to fully understand what I am doing here but this fixes the issue for me:

diff --git a/jupyter_ui_poll/_poll.py b/jupyter_ui_poll/_poll.py
index 81fb11e..3f80957 100644
--- a/jupyter_ui_poll/_poll.py
+++ b/jupyter_ui_poll/_poll.py
@@ -89,9 +89,7 @@ class KernelWrapper:
             if kernel._aborting:
                 kernel._send_abort_reply(stream, parent, ident)
             else:
-                rr = kernel.execute_request(stream, ident, parent)
-                if self._kernel_is_async:
-                    await rr
+                await kernel.execute_request(stream, ident, parent)

                 # replicate shell_dispatch behaviour
                 sys.stdout.flush()

[Kirill888]

Thanks for the report @saraedum , I can't say I have tested async + older ipykernel, it could be that kernel.execute_request returns awaitable when operating in async mode, completely disabling that check is not an option though as this would break synchronous case on series 5.* of ipykernel.

Code here can be improved though

jupyter-ui-poll/jupyter_ui_poll/_poll.py

Lines 92 to 94 in ce4e3d4

	rr = kernel.execute_request(stream, ident, parent)
	if self._kernel_is_async:
	await rr

Probably most robust is to check whether rr is "awaitable", and then await, instead of relying on per-kernel check.