Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await result of execute_request #17

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

saraedum
Copy link
Contributor

@saraedum saraedum commented Oct 8, 2021

Fixes #16.

In some cases ipykernel 5 returns an awaitable when executing a request.
We need to await it to get the correct order of execution of async cells.

Fixes Kirill888#16.

In some cases ipykernel 5 returns an awaitable when executing a request.
We need to await it to get the correct order of execution of async cells.
Copy link
Owner

@Kirill888 Kirill888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@Kirill888 Kirill888 merged commit a4b990d into Kirill888:develop Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async cells are sometimes executed out of order
2 participants