-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n7studios
requested review from
a team,
noelherrick and
corydhmiller
and removed request for
a team
March 2, 2023 18:16
…and legacy landing pages
… docblock standards
Apply Coding Standards
Improve `get_resource()`
Fix `get_subscriber_id()` by email performance
…ubscribed in the same second
This is no longer needed, as we query the API by `email_address`, so inspecting the response’s `total_subscribers` is sufficient.
…e-subscriber-array-check-function
…uest Move `api_version` property into `make_request()`
…function Replace `check_if_subscriber_in_array()` function
Add HTTP verb functions
Fix sort order tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.env
files, instead of a hard coded PHP fileTesting
testGetResource
fails, due to code using a third party library that's reliant on the (not recommended)file_get_contents()
. A separate PR to fix the code will result in this test passing.get_subscriber_id()
method attempting to fetch every single subscriber before finding a match by email (reported here, separate PR to follow to fix).Checklist