-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut release v0.25.4 #3952
Cut release v0.25.4 #3952
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MacOS smoke test is good except one thing. I get |
Windows smoke test behaved well other than opening multiple files via double-click. I believe this is relatively untested behavior on Windows, so I've made a new issue with #3955, and I don't believe it should block release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issues with MacOS and Windows found, but no showstoppers.
When @pierremtb is back from vacation I'll ask him more about how the updater test is supposed to work. I was able to see an example toast notification in the app, and then restarted the app to see the "new update is downloaded..." message. I don't know if I was to expect the "new update" toast to appear on first open. Things seem to be working alright regardless, just will want to confirm exact protocol. |
Thank you @nadr0 for smoke testing Linux. We are good to merge, just checking on other in-flight changes we might need to coordinate |
What's Changed
circle([yourCenterX, yourCenterY], yourRadius, sketch, tag?)
tocircle({ center: [yourCenterX, yourCenterY], radius: yourRadius }, sketch, tag?)
(Circle #3860)Full Changelog: v0.25.3...v0.25.4