Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.25.4 #3952

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Cut release v0.25.4 #3952

merged 1 commit into from
Sep 23, 2024

Conversation

Irev-Dev
Copy link
Collaborator

@Irev-Dev Irev-Dev commented Sep 23, 2024

What's Changed

  • KCL Breaking change: Circle function arguments have changed fromcircle([yourCenterX, yourCenterY], yourRadius, sketch, tag?) to circle({ center: [yourCenterX, yourCenterY], radius: yourRadius }, sketch, tag?) (Circle #3860)
  • Circle now has a point-and-click tool while sketching! (Circle #3860)

Full Changelog: v0.25.3...v0.25.4

Copy link

qa-wolf bot commented Sep 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 23, 2024 1:35pm

@franknoirot
Copy link
Collaborator

MacOS smoke test is good except one thing.

I get Permission denied when trying to run the app with the following command: /Applications/Zoo\ Modeling\ App.app ~/Documents/kcl-samples/ball-bearing/ball-bearing.kcl. If I prepend open to that, it runs fine. I upgraded to MacOS Sequoia last night so I'm not sure if that had an impact on how permissions work.

@franknoirot
Copy link
Collaborator

Windows smoke test behaved well other than opening multiple files via double-click. I believe this is relatively untested behavior on Windows, so I've made a new issue with #3955, and I don't believe it should block release.

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues with MacOS and Windows found, but no showstoppers.

@franknoirot
Copy link
Collaborator

When @pierremtb is back from vacation I'll ask him more about how the updater test is supposed to work. I was able to see an example toast notification in the app, and then restarted the app to see the "new update is downloaded..." message. I don't know if I was to expect the "new update" toast to appear on first open. Things seem to be working alright regardless, just will want to confirm exact protocol.

@franknoirot
Copy link
Collaborator

Thank you @nadr0 for smoke testing Linux. We are good to merge, just checking on other in-flight changes we might need to coordinate

@franknoirot franknoirot merged commit 1d1bb8c into main Sep 23, 2024
24 checks passed
@franknoirot franknoirot deleted the cut-release-v0.25.4 branch September 23, 2024 17:10
@pierremtb pierremtb added the release Issue tracking the process of releasing a stable version label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issue tracking the process of releasing a stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants