Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nightly and release icons from Figma #4597

Merged
merged 8 commits into from
Dec 2, 2024
Merged

Update nightly and release icons from Figma #4597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
44adcb2
Update nightly and windows icons
pierremtb Nov 27, 2024
b97f81b
Remove icon.ico, keep only icon.png, see https://www.electron.build/i…
pierremtb Nov 28, 2024
d534fdd
Revert "Remove icon.ico, keep only icon.png, see https://www.electron…
pierremtb Nov 28, 2024
9ddcc42
Update windows icons
pierremtb Nov 28, 2024
477c539
Reset windows ico
pierremtb Nov 28, 2024
7d9cd88
Test ico no margin
pierremtb Nov 28, 2024
7526f1c
Converted with freeconvert
pierremtb Nov 28, 2024
8183a50
Use convertico.com for conversion
pierremtb Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/icon-nightly.ico
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spent an absurd amount of time on this: I ended up converting those .ico files from the figma .png directly with https://convertico.com, as running ffmpeg as suggested here (after adjusting the size down to 256x256 with Preview) led to weird ugly results once opened on windows, unsure why. Note that removing the .ico files altogether and using their auto conversion as mentioned at https://www.electron.build/icons.html#windows-nsis also leads to bad results.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so annoying!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not fighting this today but wanted to make sure this was recorded somewhere haha. Thanks for approving!

Binary file not shown.
Binary file modified assets/icon-nightly.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/icon.ico
View file
Open in desktop
Binary file not shown.
Binary file modified assets/icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading