Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly and release icons from Figma #4597

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

pierremtb
Copy link
Collaborator

No description provided.

Copy link

qa-wolf bot commented Nov 27, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 28, 2024 7:42pm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spent an absurd amount of time on this: I ended up converting those .ico files from the figma .png directly with https://convertico.com, as running ffmpeg as suggested here (after adjusting the size down to 256x256 with Preview) led to weird ugly results once opened on windows, unsure why. Note that removing the .ico files altogether and using their auto conversion as mentioned at https://www.electron.build/icons.html#windows-nsis also leads to bad results.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so annoying!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not fighting this today but wanted to make sure this was recorded somewhere haha. Thanks for approving!

@pierremtb pierremtb changed the title Update nightly and windows icons Update nightly and release icons from Figma Nov 28, 2024
@pierremtb pierremtb marked this pull request as ready for review November 28, 2024 19:39
@pierremtb
Copy link
Collaborator Author

Can wait for Monday @franknoirot, all good

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so annoying!

@pierremtb pierremtb merged commit 3b171fb into main Dec 2, 2024
26 checks passed
@pierremtb pierremtb deleted the pierremtb/issue4192-nightly-icon branch December 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants