-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nightly and release icons from Figma #4597
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spent an absurd amount of time on this: I ended up converting those .ico files from the figma .png directly with https://convertico.com, as running ffmpeg as suggested here (after adjusting the size down to 256x256 with Preview) led to weird ugly results once opened on windows, unsure why. Note that removing the .ico files altogether and using their auto conversion as mentioned at https://www.electron.build/icons.html#windows-nsis also leads to bad results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so annoying!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm not fighting this today but wanted to make sure this was recorded somewhere haha. Thanks for approving!
Can wait for Monday @franknoirot, all good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so annoying!
No description provided.