Add support for Unix sockets #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ianpartridge Please could you review? @pushkarnk has an equivalent prototype for Kitura-NIO here: Kitura/Kitura-NIO#187 which seems substantially similar, though there are a couple of naming things to reconcile. |
This was referenced Mar 26, 2019
Do not create file path before bind
djones6
changed the title
ianpartridge
reviewed
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a work-in-progress for adding support for Unix domain sockets (client and server side). This includes a non-breaking version of #213 refactored from @adellibovi's PR, the equivalent server-side changes to allow listening on a Unix socket, and a test.
There is an equivalent PR for Kitura-NIO here: Kitura/Kitura-NIO#187 - naming needs to be reconciled in a few places.
Note: the level of CCurl required to support this is not available on Ubuntu 14.04. I recently removed 14.04 from the CI for this repo (#295), so the tests will pass, but the Unix socket client support will fail (at runtime) on 14.04. The same limitation may not apply to Kitura-NIO.
Motivation and Context
How Has This Been Tested?
Checklist: