Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unix domain sockets #1434

Merged
merged 7 commits into from
Apr 4, 2019
Merged

Support Unix domain sockets #1434

merged 7 commits into from
Apr 4, 2019

Conversation

djones6
Copy link
Collaborator

@djones6 djones6 commented Mar 27, 2019

Description

Depends on Kitura/Kitura-NIO#187 / Kitura/Kitura-net#296

Adds the ability to listen on a Unix domain socket, rather than an INET (TCP) port.

Motivation and Context

How Has This Been Tested?

Tests added. Updated KituraTest to run existing tests over Unix domain sockets.

Checklist:

  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@djones6 djones6 changed the title [WIP] Support Unix domain sockets Support Unix domain sockets Apr 1, 2019
Sources/Kitura/Kitura.swift Show resolved Hide resolved
Tests/KituraTests/KituraTest.swift Outdated Show resolved Hide resolved
Tests/KituraTests/KituraTest.swift Show resolved Hide resolved
@djones6
Copy link
Collaborator Author

djones6 commented Apr 3, 2019

@ianpartridge Because NIO 2 requires Swift 5, it'll be cleaner to merge #1436 first and then rebase this.

@djones6 djones6 merged commit 084dadd into master Apr 4, 2019
@djones6 djones6 deleted the unixSockets branch April 4, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants