Move HeadController from <head> to <html>
#2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We received a report of some CDash instances failing to load index.php properly. The error in the web console was: TypeError: $rootScope.queryString is undefined After further investigation, we discovered that the `<head>` element did not contain the `ng-controller="HeadController"` attribute. We are not sure what caused this behavior, and why it only occurs on some CDash instances and not others, but moving the controller to the top-level `<html>` element seems to fix the problem.
williamjallen
approved these changes
Jun 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received a report of some CDash instances failing to load index.php properly. The error in the web console was:
TypeError: $rootScope.queryString is undefined
After further investigation, we discovered that the
<head>element did not contain theng-controller="HeadController"attribute. We are not sure what caused this behavior, and why it only occurs on some CDash instances and not others, but moving the controller to the top-level<html>element seems to fix the problem.