Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HeadController from <head> to <html> #2288

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Move HeadController from <head> to <html> #2288

merged 1 commit into from
Jun 28, 2024

Commits on Jun 28, 2024

  1. Move HeadController from <head> to <html> 

    We received a report of some CDash instances failing to load index.php
properly. The error in the web console was:

  TypeError: $rootScope.queryString is undefined

After further investigation, we discovered that the `<head>` element
did not contain the `ng-controller="HeadController"` attribute.
We are not sure what caused this behavior, and why it only occurs on
some CDash instances and not others, but moving the controller to the
top-level `<html>` element seems to fix the problem.
    @zackgalbreath
    zackgalbreath committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e8ba345 View commit details
    Browse the repository at this point in the history