-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segments: opacity slider and visibile toggle #669
Conversation
PaulHax
commented
Oct 17, 2024
•
edited
Loading
edited
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
15180e7
to
38d46a7
Compare
No need to click in list.
93e349a
to
4cd5284
Compare
4cd5284
to
c8777aa
Compare
… logic Rename functions using labelMap to segmentGroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one unused import comment.
I re-ran the test in case it's transient, but if it fails again we'll take a look.
src/store/segmentGroups.ts
Outdated
@@ -26,6 +26,7 @@ import { | |||
import { FileEntry } from '../io/types'; | |||
import { ensureSameSpace } from '../io/resample/resample'; | |||
import { useDICOMStore } from './datasets-dicom'; | |||
import { vi } from 'vitest'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it!
Yes, the e2e layer test got flakey on ubuntu couple weeks ago. |