Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segments: opacity slider and visibile toggle #669

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Oct 17, 2024

image

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1bc37fe
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/67190df923929100083906a9
😎 Deploy Preview https://deploy-preview-669--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax changed the title feat(SegmentList): add opacity slider for selected segment Segments: opacity slider and visibile toggle Oct 17, 2024
@PaulHax PaulHax requested a review from floryst October 17, 2024 21:48
@PaulHax PaulHax force-pushed the segment-opacity branch 2 times, most recently from 93e349a to 4cd5284 Compare October 21, 2024 17:55
… logic

Rename functions using labelMap to segmentGroup
Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one unused import comment.

I re-ran the test in case it's transient, but if it fails again we'll take a look.

@@ -26,6 +26,7 @@ import {
import { FileEntry } from '../io/types';
import { ensureSameSpace } from '../io/resample/resample';
import { useDICOMStore } from './datasets-dicom';
import { vi } from 'vitest';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it!

@PaulHax
Copy link
Collaborator Author

PaulHax commented Oct 23, 2024

Yes, the e2e layer test got flakey on ubuntu couple weeks ago.

@PaulHax PaulHax added this pull request to the merge queue Oct 23, 2024
Merged via the queue into Kitware:main with commit 80021a2 Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants