Image List visible column control #86
Conversation
src/nrtk_explorer/app/trame_utils.py
Outdated
| return a != b | ||
|
|
||
|
|
||
| def change_checker(state, key, callback, trigger_check=diff): |
There was a problem hiding this comment.
is a lambda possible here?
There was a problem hiding this comment.
Yes, changed to lambda.
| return "transformed" not in old and "transformed" in new | ||
|
|
||
| change_checker( | ||
| self.state, "visible_columns", self.on_apply_transform, tranformed_became_visible |
There was a problem hiding this comment.
Does trame updates visible_columns if the value is the same?
There was a problem hiding this comment.
Another thing is that I would defer from adding newer abstractions that attempts to avoid code repetition when the potential "repeating" code is not repeating yet. Meaning that if this is the only state variable that needs to check that the value has changing before updating it, we might as well handle this in its callback method.
There was a problem hiding this comment.
Another thing is that I would defer from adding newer abstractions that attempts to avoid code repetition when the potential "repeating" code is not repeating yet. Meaning that if this is the only state variable that needs to check that the value has changing before updating it, we might as well handle this in its callback method.
🧑🎓
Does not compute transformed images if column is hidden.