Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category Filter only filters object detection model results, not ground truth #74

Closed
PaulHax opened this issue Jun 15, 2024 · 1 comment · Fixed by #86
Closed

Category Filter only filters object detection model results, not ground truth #74

PaulHax opened this issue Jun 15, 2024 · 1 comment · Fixed by #86

Comments

@PaulHax
Copy link
Collaborator

PaulHax commented Jun 15, 2024

Thats strange because if you

  1. "Apply" category filter with cow as a item, no images are selected
  2. Select the zebra and wildabeast image. Detection model annotates the wildabeast as cow.
  3. "Apply" category filter with cow as a item -> Surprise! Zebra/Wildabeast image is selected.
  4. Deselect Zebra/Wildabeast
  5. "Apply" category filter with cow as a item -> Surprise: no images are selected (but Zebra/Wildabeast was selected before!)

Strange that we select images based on if they are currently selected. If thats what we want, then category tags need to be updated on each image set selection.

Relevent code:
https://github.com/Kitware/nrtk-explorer/blob/main/src/nrtk_explorer/app/core.py#L146-L149

@vicentebolea
Copy link
Collaborator

Thanks for pointing this out, we probably want to filter ground truth.

PaulHax added a commit to PaulHax/nrtk-explorer that referenced this issue Jul 24, 2024
PaulHax added a commit to PaulHax/nrtk-explorer that referenced this issue Jul 24, 2024
@PaulHax PaulHax linked a pull request Jul 26, 2024 that will close this issue
PaulHax added a commit to PaulHax/nrtk-explorer that referenced this issue Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants